[GitHub] nifi issue #1482: NIFI-3449: Adding GCP Framework and GCS Processors

[jvwing <gi...@git.apache.org>]

Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1482
  
    Reviewing... It will take a bit to get a full review, but I have a couple of quick comments:
    
    1. Thanks for contributing to NiFi, this looks like a very complete and carefully crafted submission.
    
    2. The full build did not work for me, the unit tests complain about GOOGLE_APPLICATION_CREDENTIALS not being defined.  I certainly approve of testing the credentials classes, and I'm not sure what alternatives are available.  Would it be possible to include a plausibly formed but bogus JSON file in the resources directory that the tests can use instead of the default?
    
    3. The NAR does not get included in the project output.  I believe you should include something like the following in nifi-assembly/pom.xml:
    
            <dependency>
                <groupId>org.apache.nifi</groupId>
                <artifactId>nifi-gcp-nar</artifactId>
                <type>nar</type>
            </dependency>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---