You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/31 15:18:33 UTC
[GitHub] [flink] hililiwei opened a new pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
hililiwei opened a new pull request #17613:
URL: https://github.com/apache/flink/pull/17613
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
flink sql support bang equal '!='
https://issues.apache.org/jira/browse/FLINK-24536
## Brief change log
flink sql support bang equal '!='
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acd92e397a8397b8a6c8085333f7eda731a571ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "969931865",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955721245
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6d4c2789b1bb6e6248c31337e73ae88a29cfca86 (Sun Oct 31 15:22:11 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d4c2789b1bb6e6248c31337e73ae88a29cfca86 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a51409a5f04646c37099f6c321c4b638945c6838 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on a change in pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on a change in pull request #17613:
URL: https://github.com/apache/flink/pull/17613#discussion_r748026286
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.sql
+
+import org.apache.flink.streaming.api.scala._
+import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.data.RowData
+import org.apache.flink.table.planner.runtime.utils.{StreamingTestBase, TestingAppendRowDataSink}
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo
+import org.apache.flink.table.types.logical.{IntType, VarCharType}
+
+import org.junit.Assert._
+import org.junit.Test
+
+class BangEqualITCase extends StreamingTestBase {
+
+ @Test
+ def testBangEqual(): Unit = {
+
+ val sqlQueryBangEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a != 2
+ |
+ |""".stripMargin
+
+ val sqlQueryUnEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a <> 2
+ |
+ |""".stripMargin
+
+ val outputType = InternalTypeInfo.ofFields(
+ new IntType(),
+ new VarCharType(5))
+
+ val result1 = tEnv.sqlQuery(sqlQueryBangEqual).toAppendStream[RowData]
+ val sink1 = new TestingAppendRowDataSink(outputType)
+ result1.addSink(sink1).setParallelism(1)
+
+ val result2 = tEnv.sqlQuery(sqlQueryUnEqual).toAppendStream[RowData]
+ val sink2 = new TestingAppendRowDataSink(outputType)
+ result2.addSink(sink2).setParallelism(1)
+
+ env.execute()
+
+ val expected = List("+I(1,Alice)", "+I(1,Bob)")
Review comment:
thx. That's make sense. Modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a51409a5f04646c37099f6c321c4b638945c6838 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732)
* acd92e397a8397b8a6c8085333f7eda731a571ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "969931865",
"triggerType" : "MANUAL"
}, {
"hash" : "fd33b64907458bb1785be3cf5efd27f6be4f6100",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26601",
"triggerID" : "fd33b64907458bb1785be3cf5efd27f6be4f6100",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
* fd33b64907458bb1785be3cf5efd27f6be4f6100 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26601)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "969931865",
"triggerType" : "MANUAL"
}, {
"hash" : "fd33b64907458bb1785be3cf5efd27f6be4f6100",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fd33b64907458bb1785be3cf5efd27f6be4f6100",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
* fd33b64907458bb1785be3cf5efd27f6be4f6100 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d4c2789b1bb6e6248c31337e73ae88a29cfca86 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685)
* a51409a5f04646c37099f6c321c4b638945c6838 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d4c2789b1bb6e6248c31337e73ae88a29cfca86 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685)
* a51409a5f04646c37099f6c321c4b638945c6838 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d4c2789b1bb6e6248c31337e73ae88a29cfca86 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301
@MartijnVisser added two test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301
@MartijnVisser added two test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a51409a5f04646c37099f6c321c4b638945c6838 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732)
* acd92e397a8397b8a6c8085333f7eda731a571ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "969931865",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acd92e397a8397b8a6c8085333f7eda731a571ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398)
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on a change in pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on a change in pull request #17613:
URL: https://github.com/apache/flink/pull/17613#discussion_r748025602
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.sql
+
+import org.apache.flink.streaming.api.scala._
+import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.data.RowData
+import org.apache.flink.table.planner.runtime.utils.{StreamingTestBase, TestingAppendRowDataSink}
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo
+import org.apache.flink.table.types.logical.{IntType, VarCharType}
+
+import org.junit.Assert._
+import org.junit.Test
+
+class BangEqualITCase extends StreamingTestBase {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "969931865",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-969931865
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-974573248
@RocMarshal @MartijnVisser could you PTAL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26421",
"triggerID" : "969931865",
"triggerType" : "MANUAL"
}, {
"hash" : "fd33b64907458bb1785be3cf5efd27f6be4f6100",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26601",
"triggerID" : "fd33b64907458bb1785be3cf5efd27f6be4f6100",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd33b64907458bb1785be3cf5efd27f6be4f6100 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26601)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
}, {
"hash" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398",
"triggerID" : "acd92e397a8397b8a6c8085333f7eda731a571ad",
"triggerType" : "PUSH"
}, {
"hash" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acd92e397a8397b8a6c8085333f7eda731a571ad Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=26398)
* d2fb15cc1d92c0ecd9428869d6e94bbbea9f4a04 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on a change in pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on a change in pull request #17613:
URL: https://github.com/apache/flink/pull/17613#discussion_r748028182
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.sql
+
+import org.apache.flink.streaming.api.scala._
+import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.data.RowData
+import org.apache.flink.table.planner.runtime.utils.{StreamingTestBase, TestingAppendRowDataSink}
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo
+import org.apache.flink.table.types.logical.{IntType, VarCharType}
+
+import org.junit.Assert._
+import org.junit.Test
+
+class BangEqualITCase extends StreamingTestBase {
+
+ @Test
+ def testBangEqual(): Unit = {
+
+ val sqlQueryBangEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a != 2
+ |
+ |""".stripMargin
+
+ val sqlQueryUnEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a <> 2
Review comment:
In fact, '<>'Already covered by another case, I just want to show that '!=' gives the same result, let's just keep '!= '.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a change in pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #17613:
URL: https://github.com/apache/flink/pull/17613#discussion_r747186368
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.sql
+
+import org.apache.flink.streaming.api.scala._
+import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.data.RowData
+import org.apache.flink.table.planner.runtime.utils.{StreamingTestBase, TestingAppendRowDataSink}
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo
+import org.apache.flink.table.types.logical.{IntType, VarCharType}
+
+import org.junit.Assert._
+import org.junit.Test
+
+class BangEqualITCase extends StreamingTestBase {
Review comment:
Could you check the case in Batched mode ?
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.sql
+
+import org.apache.flink.streaming.api.scala._
+import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.data.RowData
+import org.apache.flink.table.planner.runtime.utils.{StreamingTestBase, TestingAppendRowDataSink}
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo
+import org.apache.flink.table.types.logical.{IntType, VarCharType}
+
+import org.junit.Assert._
+import org.junit.Test
+
+class BangEqualITCase extends StreamingTestBase {
+
+ @Test
+ def testBangEqual(): Unit = {
+
+ val sqlQueryBangEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a != 2
+ |
+ |""".stripMargin
+
+ val sqlQueryUnEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a <> 2
+ |
+ |""".stripMargin
+
+ val outputType = InternalTypeInfo.ofFields(
+ new IntType(),
+ new VarCharType(5))
+
+ val result1 = tEnv.sqlQuery(sqlQueryBangEqual).toAppendStream[RowData]
+ val sink1 = new TestingAppendRowDataSink(outputType)
+ result1.addSink(sink1).setParallelism(1)
+
+ val result2 = tEnv.sqlQuery(sqlQueryUnEqual).toAppendStream[RowData]
+ val sink2 = new TestingAppendRowDataSink(outputType)
+ result2.addSink(sink2).setParallelism(1)
+
+ env.execute()
+
+ val expected = List("+I(1,Alice)", "+I(1,Bob)")
Review comment:
It would be better if you could describe the table columns by TableFactoryHarness and describe the table result by Row instead of string, as mentioned from this [pr](https://github.com/apache/flink/pull/17352#discussion_r715626383) by @Airblader .
##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/BangEqualITCase.scala
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.runtime.stream.sql
+
+import org.apache.flink.streaming.api.scala._
+import org.apache.flink.table.api.bridge.scala._
+import org.apache.flink.table.data.RowData
+import org.apache.flink.table.planner.runtime.utils.{StreamingTestBase, TestingAppendRowDataSink}
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo
+import org.apache.flink.table.types.logical.{IntType, VarCharType}
+
+import org.junit.Assert._
+import org.junit.Test
+
+class BangEqualITCase extends StreamingTestBase {
+
+ @Test
+ def testBangEqual(): Unit = {
+
+ val sqlQueryBangEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a != 2
+ |
+ |""".stripMargin
+
+ val sqlQueryUnEqual =
+ """
+ |SELECT * FROM
+ | (VALUES (1, 'Bob'), (1, 'Alice'), (2, 'Lily')) T(a, b)
+ |WHERE a <> 2
Review comment:
Would the sql statement be compressed by extracting '<>' & '!=' into a local variable for reusing code ?
Or split the test case into two test cases, testBangEqual() & sqlQueryUnEqual().
(only a minor comment.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25685",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
}, {
"hash" : "a51409a5f04646c37099f6c321c4b638945c6838",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732",
"triggerID" : "a51409a5f04646c37099f6c321c4b638945c6838",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a51409a5f04646c37099f6c321c4b638945c6838 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25732)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
hililiwei commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301
@MartijnVisser added two test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17613:
URL: https://github.com/apache/flink/pull/17613#issuecomment-955719048
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6d4c2789b1bb6e6248c31337e73ae88a29cfca86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d4c2789b1bb6e6248c31337e73ae88a29cfca86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org