You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/15 23:04:53 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #2245: Move LogicalPlan to datafusion-expr crate
andygrove opened a new issue, #2245:
URL: https://github.com/apache/arrow-datafusion/issues/2245
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
I am trying to implement support for the expression `EXISTS (<subquery>` and this requires having a new `Expr` variant that refers to a `LogicalPlan`. However, this is not possible because `LogicalPlan` is in the core `datafusion` crate which depends on the `datafusion-expr` crate that contains `Expr`, and therefore it is not possible to reference `LogicalPlan` from `Expr`.
**Describe the solution you'd like**
`LogicalPlan` and `Expr` should live in the same crate IMO so I propose moving `LogicalPlan` into the `datafusion-expr` crate.
**Describe alternatives you've considered**
None
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] matthewmturner commented on issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on issue #2245:
URL: https://github.com/apache/arrow-datafusion/issues/2245#issuecomment-1100467705
Would it make sense to call this crate 'datafusion-logical-plan' after this change? At least to me it wouldn't be immediately obvious that logical plan was there from naming. But maybe that's just me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2245:
URL: https://github.com/apache/arrow-datafusion/issues/2245#issuecomment-1100689308
We need to address https://github.com/apache/arrow-datafusion/issues/2247 before we can make progress on this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2245:
URL: https://github.com/apache/arrow-datafusion/issues/2245#issuecomment-1100468411
> Would it make sense to call this crate 'datafusion-logical-plan' after this change? At least to me it wouldn't be immediately obvious that logical plan was there from naming. But maybe that's just me.
Yes, that would make more sense to me too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
andygrove closed issue #2245: Move LogicalPlan to datafusion-expr crate
URL: https://github.com/apache/arrow-datafusion/issues/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2245:
URL: https://github.com/apache/arrow-datafusion/issues/2245#issuecomment-1100676403
So this doesn't look like it can work. The logical plan depends on the datasource module, which depends on the physical plan :disappointed:
It might be better just to move the expressions back into the core crate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
andygrove closed issue #2245: Move LogicalPlan to datafusion-expr crate
URL: https://github.com/apache/arrow-datafusion/issues/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jychen7 commented on issue #2245: Move LogicalPlan to datafusion-expr crate
Posted by GitBox <gi...@apache.org>.
jychen7 commented on issue #2245:
URL: https://github.com/apache/arrow-datafusion/issues/2245#issuecomment-1100756618
> Would it make sense to call this crate 'datafusion-logical-plan' after this change? At least to me it wouldn't be immediately obvious that logical plan was there from naming. But maybe that's just me.
+1
[minor] given we also have `physical-expr`, maybe we call it `logical-expr`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org