You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by re...@apache.org on 2015/01/07 01:23:26 UTC
[2/5] incubator-streams git commit: STREAMS-261 | Necessary changes
to back off strategy
STREAMS-261 | Necessary changes to back off strategy
Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/3ac7be05
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/3ac7be05
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/3ac7be05
Branch: refs/heads/master
Commit: 3ac7be0516f31249f2bffcc2d6dcffd37a0c68c9
Parents: 15f1aef
Author: Robert Douglas <rd...@w2ogroup.com>
Authored: Mon Jan 5 17:08:25 2015 -0600
Committer: Robert Douglas <rd...@w2ogroup.com>
Committed: Mon Jan 5 17:08:25 2015 -0600
----------------------------------------------------------------------
.../facebook/provider/page/FacebookPageDataCollector.java | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/3ac7be05/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java
index 3bf93ca..2411390 100644
--- a/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java
+++ b/streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/provider/page/FacebookPageDataCollector.java
@@ -47,9 +47,13 @@ public class FacebookPageDataCollector extends FacebookDataCollector {
} catch (FacebookException fe) {
LOGGER.error("Facebook returned an exception : {}", fe);
LOGGER.error("Facebook returned an exception while trying to get feed for page, {} : {}", pageId, fe.getMessage());
- //TODO Rate limit exceptions with facebook4j unclear http://facebook4j.org/oldjavadocs/1.1.12-2.0.0/2.0.0/index.html?facebook4j/internal/http/HttpResponseCode.html
- // back off at all exceptions until figured out.
- super.backOff.backOff();
+
+ int errorCode = fe.getErrorCode();
+
+ //Some sort of rate limiting
+ if(errorCode == 17 || errorCode == 4 || errorCode == 341) {
+ super.backOff.backOff();
+ }
}
}
throw new Exception("Failed to get data from facebook after "+MAX_ATTEMPTS);