You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2008/03/18 18:51:24 UTC

[jira] Commented: (HADOOP-3036) Fix findBugs warnings in UpgradeUtilities.

    [ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579946#action_12579946 ] 

Nigel Daley commented on HADOOP-3036:
-------------------------------------

Code review, 2 nits:

* looks like 1st "continue" isn't indented properly in the patch
* please add brackets for both if statements that have single-line bodies (per Java code style conventions)




> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
>                 Key: HADOOP-3036
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3036
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, test
>    Affects Versions: 0.15.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.17.0
>
>         Attachments: UpgradeUtilityBugs.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.