You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/11/19 16:25:13 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1017: MINIFICPP-1515 - Add integration tests testing different flowfile sizes in a simple flow

lordgamez commented on pull request #1017:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1017#issuecomment-974216630


   > This test passes for me locally after rebasing on top of main, so I think it's ready for merging.
   > 
   > In order to not increase the running time of the CI job by too much, I suggest making the timeout configurable and lower, eg. 1 second for the first 3 tests and 10 seconds for the last two.
   
   Rebased and fixed the runtime issues (the file observer wanted to log the content of the file on every modification which prevented to get the actual notifications in time when large files flooded the logger), I think this could be merged if all tests pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org