[GitHub] [iceberg] singhpk234 commented on pull request #7391: Build: Run Iceberg with JDK 17

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on PR #7391:
URL: https://github.com/apache/iceberg/pull/7391#issuecomment-1522009282

   >  I think it would be good to also double-check the difference in the sizes that required the test changes
   
   +1 here is the [analysis](https://github.com/apache/iceberg/pull/7391#discussion_r1173527238) for the same, basically JDK 8 was reporting column size for `binaryCol`for 44 where as JDK 17 was reporting it as `43`, these stats were directly taken from the parquet footer hence to make the size / stats of the parquet file written env independent, I directly read the columnSize from dataFile itself, and made the changes here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org