[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on pull request #1418: HDDS-4209. S3A Filesystem does not work with Ozone S3.

[GitBox <gi...@apache.org>]

bharatviswa504 edited a comment on pull request #1418:
URL: https://github.com/apache/hadoop-ozone/pull/1418#issuecomment-691794808


   >In this specific case, intermediate directories will be created even if OZONE_OM_ENABLE_FILESYSTEM_PATHS is not >enabled. I created HDDS-4238 to make it more visible:
   
   Good point. Might be we need to have a flag/param in createDirectory to say create intermediate directories or not. In this way, we can use this flag from the client in proto along with the normalization flag(current config in code) to create intermediate directories or not.
   
   Example:
   boolean zerobyteFile default=false
   
   It Will be set to true only from S3G, and when create directory comes to OM, it uses a normalization flag to create intermediate directories, else just create an entry without any intermediate directories.
   
   
   
   >I think it's a safer approach to fix the normalization (in case of OZONE_OM_ENABLE_FILESYSTEM_PATHS enabled), to >avoid the removal of / from the end if the file size is zero.
   
   My reasoning to take this approach is once HDDS-2939 comes in Ozone `directory` and `key` are not distinguished with trailing "/". So, using putObject when length is zero might not be a correct solution in OM, as the entries will be still created in keyTable. For this, if we want to go this route, then might be if  ending with "/" and size is zero, in putObject we should create an entry in the directory table. So, instead of doing these changes in OM, I thought it could be safer to do in S3G. As in S3G when someones tries to create a zero byte file with trailing "/" might be they want to simulate like a directory in Object Store.
   
   Let me know your thoughts on how to proceed?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org