You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by vpranckaitis <gi...@git.apache.org> on 2018/07/28 04:48:28 UTC
[GitHub] lucene-solr pull request #426: SOLR-12595: CloudSolrClient.Builder accepts Z...
GitHub user vpranckaitis opened a pull request:
https://github.com/apache/lucene-solr/pull/426
SOLR-12595: CloudSolrClient.Builder accepts ZK connection strings
Added additional constructor to `CloudSolrClient.Builder` which accepts ZooKeeper connection strings.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vpranckaitis/lucene-solr SOLR-12595_cloud_solr_client_builder_constructor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #426
----
commit 2551b9d917c2ceb23cf16567f16870ceef725ba7
Author: Vilius Pranckaitis <vp...@...>
Date: 2018-07-28T04:40:36Z
SOLR-12595: CloudSolrClient.Builder accepts ZK connection strings
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #426: SOLR-12595: CloudSolrClient.Builder accepts Z...
Posted by vpranckaitis <gi...@git.apache.org>.
Github user vpranckaitis commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/426#discussion_r205932897
--- Diff: solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientBuilderTest.java ---
@@ -63,22 +66,20 @@ public void testSeveralZkHostsSpecifiedSingly() throws IOException {
}
@Test
- public void testSeveralZkHostsSpecifiedTogether() throws IOException {
--- End diff --
This test was exactly the same as the one above, just with differently formatted newlines.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org