[GitHub] [druid] suneet-s commented on a change in pull request #9200: Optimize JoinCondition matching

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #9200: Optimize JoinCondition matching
URL: https://github.com/apache/druid/pull/9200#discussion_r368080871
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/join/JoinConditionAnalysis.java
 ##########
 @@ -133,26 +142,23 @@ public String getOriginalExpression()
    */
   public boolean isAlwaysFalse()
   {
-    return nonEquiConditions.stream()
-                            .anyMatch(expr -> expr.isLiteral() && !expr.eval(ExprUtils.nilBindings()).asBoolean());
+    return anyFalseLiteralNonEquiConditions;
 
 Review comment:
   yeah. I wasn't sure if isAlwaysFalse could be more complex going forward. This is clearer - it took me a while to wrap my head around what isAlwaysFalse was trying to check. Added comments, and used `isAlways...`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org