You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nifi.apache.org by brosander <gi...@git.apache.org> on 2016/06/17 22:16:53 UTC

[GitHub] nifi-minifi pull request #19: MINIFI-40 - Defaulting to empty string for key...

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi-minifi/pull/19

    MINIFI-40 - Defaulting to empty string for keystore, truststore, sslP\u2026

    \u2026rotocol

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi MINIFI-40

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit 4328421021f42a52ac83076ed5834cf31f84a865
Author: Bryan Rosander <br...@gmail.com>
Date:   2016-06-17T20:48:50Z

    MINIFI-40 - Defaulting to empty string for keystore, truststore, sslProtocol

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #19: MINIFI-40 - Defaulting to empty string for key...

Posted by JPercivall <gi...@git.apache.org>.

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/19#discussion_r68591275
  
    --- Diff: minifi-bootstrap/pom.xml ---
    @@ -43,6 +43,10 @@ limitations under the License.
             </dependency>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-properties</artifactId>
    --- End diff --
    
    Instead of adding another pom dependency for one static helper method I would prefer to just create a new private one that does it:
        private static boolean nullOrEmpty(String input) {
            return input == null || input.isEmpty();
        }


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #19: MINIFI-40 - Defaulting to empty string for key...

Posted by brosander <gi...@git.apache.org>.

GitHub user brosander reopened a pull request:

    https://github.com/apache/nifi-minifi/pull/19

    MINIFI-40 - Defaulting to empty string for keystore, truststore, sslP\u2026

    \u2026rotocol

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi-minifi MINIFI-40

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit fb2b9f2dcaab09fa18510417d32b845cc15f36e7
Author: Bryan Rosander <br...@gmail.com>
Date:   2016-06-17T20:48:50Z

    MINIFI-40 - Defaulting to empty string for keystore, truststore, sslProtocol, keystoreType, keystorePassword, keyPassword, truststoreType

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #19: MINIFI-40 - Defaulting to empty string for key...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-minifi/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi pull request #19: MINIFI-40 - Defaulting to empty string for key...

Posted by brosander <gi...@git.apache.org>.

Github user brosander closed the pull request at:

    https://github.com/apache/nifi-minifi/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---