You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Christopher Freeman <cf...@linkedin.com> on 2013/09/13 04:44:20 UTC
Review Request 14111: (trunk) Added support for Scala 2.10 builds while
maintaining compatibility with 2.8.x
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14111/
-----------------------------------------------------------
Review request for kafka and Neha Narkhede.
Bugs: KAFKA-1046
https://issues.apache.org/jira/browse/KAFKA-1046
Repository: kafka
Description
-------
Refer to https://reviews.apache.org/r/14013
This RB serves the same purpose but the attached diff is against trunk
Diffs
-----
core/build.sbt c54cf44
core/src/main/scala/kafka/Kafka.scala dafb1ee
core/src/main/scala/kafka/admin/AddPartitionsCommand.scala fd41661
core/src/main/scala/kafka/admin/AdminUtils.scala 83ba729
core/src/main/scala/kafka/admin/DeleteTopicCommand.scala 3da4518
core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 53fc433
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala aa61fa1
core/src/main/scala/kafka/client/ClientUtils.scala cc526ec
core/src/main/scala/kafka/cluster/Broker.scala b03dea2
core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 140f2e3
core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala fa6b213
core/src/main/scala/kafka/consumer/SimpleConsumer.scala 77e1ce2
core/src/main/scala/kafka/consumer/TopicCount.scala c8e8406
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 08c9e4f
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala df83baa
core/src/main/scala/kafka/controller/ControllerChannelManager.scala ed1ce0b
core/src/main/scala/kafka/controller/KafkaController.scala ab18b7a
core/src/main/scala/kafka/controller/PartitionStateMachine.scala a084830
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala c964857
core/src/main/scala/kafka/javaapi/FetchRequest.scala 83d8cbc
core/src/main/scala/kafka/javaapi/Implicits.scala 9a63914
core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 32033d6
core/src/main/scala/kafka/javaapi/OffsetCommitResponse.scala d1c50c4
core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 64d134b
core/src/main/scala/kafka/javaapi/OffsetFetchResponse.scala 9f83c1b
core/src/main/scala/kafka/javaapi/OffsetRequest.scala 3565a15
core/src/main/scala/kafka/javaapi/TopicMetadata.scala 97b6dcd
core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala 5f80df7
core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala 14c4c8a
core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala 0a95248
core/src/main/scala/kafka/javaapi/producer/Producer.scala 7265328
core/src/main/scala/kafka/log/Log.scala 626eb8f
core/src/main/scala/kafka/log/LogConfig.scala 48660bc
core/src/main/scala/kafka/log/LogManager.scala d039f9d
core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala cab1864
core/src/main/scala/kafka/producer/SyncProducer.scala 306f200
core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 65613ce
core/src/main/scala/kafka/producer/async/ProducerSendThread.scala 2b41a49
core/src/main/scala/kafka/server/AbstractFetcherThread.scala d5addb3
core/src/main/scala/kafka/server/KafkaApis.scala 0287f87
core/src/main/scala/kafka/server/KafkaServerStartable.scala 5be65e9
core/src/main/scala/kafka/server/ReplicaManager.scala 3ca4419
core/src/main/scala/kafka/server/TopicConfigManager.scala 5814cb7
core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala f1f0625
core/src/main/scala/kafka/tools/ImportZkOffsets.scala 55709b5
core/src/main/scala/kafka/tools/JmxTool.scala 7e424e7
core/src/main/scala/kafka/tools/MirrorMaker.scala 6fb545a
core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 7629329
core/src/main/scala/kafka/utils/Annotations.scala 28269eb
core/src/main/scala/kafka/utils/Annotations_2.8.scala PRE-CREATION
core/src/main/scala/kafka/utils/Annotations_2.9+.scala PRE-CREATION
core/src/main/scala/kafka/utils/Json.scala 3f1252c
core/src/main/scala/kafka/utils/KafkaScheduler.scala 73457e1
core/src/main/scala/kafka/utils/Mx4jLoader.scala 64d84cc
core/src/main/scala/kafka/utils/Pool.scala 9a86eab
core/src/main/scala/kafka/utils/VerifiableProperties.scala 9009a9d
core/src/main/scala/kafka/utils/ZkUtils.scala 4094dcb
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala abcbed8
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 121b6c5
core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 9f243f0
core/src/test/scala/unit/kafka/javaapi/message/BaseMessageSetTestCases.scala abee11b
core/src/test/scala/unit/kafka/log/LogTest.scala b7f43e2
core/src/test/scala/unit/kafka/metrics/KafkaTimerTest.scala fe5bc09
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 74a2743
core/src/test/scala/unit/kafka/producer/ProducerTest.scala f546c15
core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala 6fa1abc
core/src/test/scala/unit/kafka/utils/TestUtils.scala 2375758
perf/src/main/scala/kafka/perf/ConsumerPerformance.scala 3158a22
project/Build.scala b3858f3
Diff: https://reviews.apache.org/r/14111/diff/
Testing
-------
Thanks,
Christopher Freeman
Re: Review Request 14111: (trunk) Added support for Scala 2.10 builds while
maintaining compatibility with 2.8.x
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14111/#review26085
-----------------------------------------------------------
Ship it!
Looks great. Thanks a lot for you contribution!
- Neha Narkhede
On Sept. 13, 2013, 2:44 a.m., Christopher Freeman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14111/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 2:44 a.m.)
>
>
> Review request for kafka and Neha Narkhede.
>
>
> Bugs: KAFKA-1046
> https://issues.apache.org/jira/browse/KAFKA-1046
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Refer to https://reviews.apache.org/r/14013
>
> This RB serves the same purpose but the attached diff is against trunk
>
>
> Diffs
> -----
>
> core/build.sbt c54cf44
> core/src/main/scala/kafka/Kafka.scala dafb1ee
> core/src/main/scala/kafka/admin/AddPartitionsCommand.scala fd41661
> core/src/main/scala/kafka/admin/AdminUtils.scala 83ba729
> core/src/main/scala/kafka/admin/DeleteTopicCommand.scala 3da4518
> core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala 53fc433
> core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala aa61fa1
> core/src/main/scala/kafka/client/ClientUtils.scala cc526ec
> core/src/main/scala/kafka/cluster/Broker.scala b03dea2
> core/src/main/scala/kafka/consumer/ConsoleConsumer.scala 140f2e3
> core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala fa6b213
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala 77e1ce2
> core/src/main/scala/kafka/consumer/TopicCount.scala c8e8406
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 08c9e4f
> core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala df83baa
> core/src/main/scala/kafka/controller/ControllerChannelManager.scala ed1ce0b
> core/src/main/scala/kafka/controller/KafkaController.scala ab18b7a
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala a084830
> core/src/main/scala/kafka/controller/ReplicaStateMachine.scala c964857
> core/src/main/scala/kafka/javaapi/FetchRequest.scala 83d8cbc
> core/src/main/scala/kafka/javaapi/Implicits.scala 9a63914
> core/src/main/scala/kafka/javaapi/OffsetCommitRequest.scala 32033d6
> core/src/main/scala/kafka/javaapi/OffsetCommitResponse.scala d1c50c4
> core/src/main/scala/kafka/javaapi/OffsetFetchRequest.scala 64d134b
> core/src/main/scala/kafka/javaapi/OffsetFetchResponse.scala 9f83c1b
> core/src/main/scala/kafka/javaapi/OffsetRequest.scala 3565a15
> core/src/main/scala/kafka/javaapi/TopicMetadata.scala 97b6dcd
> core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala 5f80df7
> core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala 14c4c8a
> core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala 0a95248
> core/src/main/scala/kafka/javaapi/producer/Producer.scala 7265328
> core/src/main/scala/kafka/log/Log.scala 626eb8f
> core/src/main/scala/kafka/log/LogConfig.scala 48660bc
> core/src/main/scala/kafka/log/LogManager.scala d039f9d
> core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala cab1864
> core/src/main/scala/kafka/producer/SyncProducer.scala 306f200
> core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala 65613ce
> core/src/main/scala/kafka/producer/async/ProducerSendThread.scala 2b41a49
> core/src/main/scala/kafka/server/AbstractFetcherThread.scala d5addb3
> core/src/main/scala/kafka/server/KafkaApis.scala 0287f87
> core/src/main/scala/kafka/server/KafkaServerStartable.scala 5be65e9
> core/src/main/scala/kafka/server/ReplicaManager.scala 3ca4419
> core/src/main/scala/kafka/server/TopicConfigManager.scala 5814cb7
> core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala f1f0625
> core/src/main/scala/kafka/tools/ImportZkOffsets.scala 55709b5
> core/src/main/scala/kafka/tools/JmxTool.scala 7e424e7
> core/src/main/scala/kafka/tools/MirrorMaker.scala 6fb545a
> core/src/main/scala/kafka/tools/SimpleConsumerShell.scala 7629329
> core/src/main/scala/kafka/utils/Annotations.scala 28269eb
> core/src/main/scala/kafka/utils/Annotations_2.8.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Annotations_2.9+.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Json.scala 3f1252c
> core/src/main/scala/kafka/utils/KafkaScheduler.scala 73457e1
> core/src/main/scala/kafka/utils/Mx4jLoader.scala 64d84cc
> core/src/main/scala/kafka/utils/Pool.scala 9a86eab
> core/src/main/scala/kafka/utils/VerifiableProperties.scala 9009a9d
> core/src/main/scala/kafka/utils/ZkUtils.scala 4094dcb
> core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala abcbed8
> core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala 121b6c5
> core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 9f243f0
> core/src/test/scala/unit/kafka/javaapi/message/BaseMessageSetTestCases.scala abee11b
> core/src/test/scala/unit/kafka/log/LogTest.scala b7f43e2
> core/src/test/scala/unit/kafka/metrics/KafkaTimerTest.scala fe5bc09
> core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 74a2743
> core/src/test/scala/unit/kafka/producer/ProducerTest.scala f546c15
> core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala 6fa1abc
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 2375758
> perf/src/main/scala/kafka/perf/ConsumerPerformance.scala 3158a22
> project/Build.scala b3858f3
>
> Diff: https://reviews.apache.org/r/14111/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christopher Freeman
>
>