You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/10 05:45:37 UTC
[GitHub] [doris] ByteYue commented on a diff in pull request #15762: [Bug](predicate) add double predicate creator
ByteYue commented on code in PR #15762:
URL: https://github.com/apache/doris/pull/15762#discussion_r1065353532
##########
be/src/olap/predicate_creator.h:
##########
@@ -163,6 +166,9 @@ inline std::unique_ptr<PredicateCreator<ConditionType>> get_creator(const FieldT
case OLAP_FIELD_TYPE_LARGEINT: {
return std::make_unique<IntegerPredicateCreator<TYPE_LARGEINT, PT, ConditionType>>();
}
+ case OLAP_FIELD_TYPE_DOUBLE: {
Review Comment:
> Maybe need add FLOAT also
😂My bad, I added both float and double in another machine but only added double in the machine where i created this pr.
Already added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org