You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/02 07:59:53 UTC
[GitHub] [apisix-website] SkyeYoung opened a new pull request #1002: chore: reformat scripts and config
SkyeYoung opened a new pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002
Changes:
- reformat scripts and config
- add some missing eslint and git rules
Screenshots of the change:
none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] yzeng25 commented on a change in pull request #1002: chore: reformat scripts and config
Posted by GitBox <gi...@apache.org>.
yzeng25 commented on a change in pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002#discussion_r841056808
##########
File path: scripts/common.js
##########
@@ -1,60 +1,58 @@
const projects = [
{
- name: "apisix-ingress-controller",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-ingress-controller',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix",
- branch: "master",
- hasChangelog: true
+ name: 'apisix',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-dashboard",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-dashboard',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-docker",
- branch: "master",
+ name: 'apisix-docker',
+ branch: 'master',
hasChangelog: false,
},
{
- name: "apisix-helm-chart",
- branch: "master",
+ name: 'apisix-helm-chart',
+ branch: 'master',
hasChangelog: false,
},
{
- name: "apisix-java-plugin-runner",
- branch: "main",
- hasChangelog: true
+ name: 'apisix-java-plugin-runner',
+ branch: 'main',
+ hasChangelog: true,
},
{
- name: "apisix-go-plugin-runner",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-go-plugin-runner',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-python-plugin-runner",
- branch: "master",
- hasChangelog: true
- }
+ name: 'apisix-python-plugin-runner',
+ branch: 'master',
+ hasChangelog: true,
+ },
];
-const languages = ["en", "zh", "es"];
+const languages = ['en', 'zh', 'es'];
Review comment:
I think we don't need es(Spanish) for now. There was a contributor doing Spanish and he passed away about a year ago, then the process of translation is stopped, see https://github.com/apache/apisix/issues/3587#issuecomment-818397330.
I would suggest to transfer this part as an issue and see if anyone could pick it up.
```suggestion
const languages = ['en', 'zh'];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on a change in pull request #1002: chore: reformat scripts and config
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on a change in pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002#discussion_r841078871
##########
File path: scripts/common.js
##########
@@ -1,60 +1,58 @@
const projects = [
{
- name: "apisix-ingress-controller",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-ingress-controller',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix",
- branch: "master",
- hasChangelog: true
+ name: 'apisix',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-dashboard",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-dashboard',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-docker",
- branch: "master",
+ name: 'apisix-docker',
+ branch: 'master',
hasChangelog: false,
},
{
- name: "apisix-helm-chart",
- branch: "master",
+ name: 'apisix-helm-chart',
+ branch: 'master',
hasChangelog: false,
},
{
- name: "apisix-java-plugin-runner",
- branch: "main",
- hasChangelog: true
+ name: 'apisix-java-plugin-runner',
+ branch: 'main',
+ hasChangelog: true,
},
{
- name: "apisix-go-plugin-runner",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-go-plugin-runner',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-python-plugin-runner",
- branch: "master",
- hasChangelog: true
- }
+ name: 'apisix-python-plugin-runner',
+ branch: 'master',
+ hasChangelog: true,
+ },
];
-const languages = ["en", "zh", "es"];
+const languages = ['en', 'zh', 'es'];
Review comment:
> I would suggest to transfer this part as an issue and see if anyone could pick it up.
🤣 Let's create an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #1002: chore: reformat scripts and config
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002#issuecomment-1086581778
### <span aria-hidden="true">✅</span> Deploy Preview for *apache-apisix* ready!
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 9f22b1f9d2e0ef7ba9a6617ead12e016064d8c5e |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/624802691025bd0009965843 |
|<span aria-hidden="true">😎</span> Deploy Preview | https://deploy-preview-1002--apache-apisix.netlify.app |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
_To edit notification comments on pull requests, go to your [Netlify site settings](https://app.netlify.com/sites/apache-apisix/settings/deploys#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on a change in pull request #1002: chore: reformat scripts and config
Posted by GitBox <gi...@apache.org>.
SkyeYoung commented on a change in pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002#discussion_r841161606
##########
File path: scripts/common.js
##########
@@ -1,60 +1,58 @@
const projects = [
{
- name: "apisix-ingress-controller",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-ingress-controller',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix",
- branch: "master",
- hasChangelog: true
+ name: 'apisix',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-dashboard",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-dashboard',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-docker",
- branch: "master",
+ name: 'apisix-docker',
+ branch: 'master',
hasChangelog: false,
},
{
- name: "apisix-helm-chart",
- branch: "master",
+ name: 'apisix-helm-chart',
+ branch: 'master',
hasChangelog: false,
},
{
- name: "apisix-java-plugin-runner",
- branch: "main",
- hasChangelog: true
+ name: 'apisix-java-plugin-runner',
+ branch: 'main',
+ hasChangelog: true,
},
{
- name: "apisix-go-plugin-runner",
- branch: "master",
- hasChangelog: true
+ name: 'apisix-go-plugin-runner',
+ branch: 'master',
+ hasChangelog: true,
},
{
- name: "apisix-python-plugin-runner",
- branch: "master",
- hasChangelog: true
- }
+ name: 'apisix-python-plugin-runner',
+ branch: 'master',
+ hasChangelog: true,
+ },
];
-const languages = ["en", "zh", "es"];
+const languages = ['en', 'zh', 'es'];
Review comment:
> 🤣 Let's create an issue.
I've created https://github.com/apache/apisix-website/issues/1003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #1002: chore: reformat scripts and config
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1002:
URL: https://github.com/apache/apisix-website/pull/1002#issuecomment-1086581778
### <span aria-hidden="true">👷</span> Deploy Preview for *apache-apisix* processing.
| Name | Link |
|---------------------------------|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 9f22b1f9d2e0ef7ba9a6617ead12e016064d8c5e |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-apisix/deploys/624802691025bd0009965843 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org