[GitHub] [skywalking] wu-sheng commented on a change in pull request #5390: Support in filter expressions in OAL

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5390:
URL: https://github.com/apache/skywalking/pull/5390#discussion_r477169957



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/expression/EqualMatch.java
##########
@@ -23,6 +23,19 @@
 
 @FilterMatcher("stringMatch")
 public class EqualMatch {
+
+    public boolean match(String left, String right) {

Review comment:
       `equal match` support literal string?

##########
File path: oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/parser/ConditionExpression.java
##########
@@ -18,18 +18,42 @@
 
 package org.apache.skywalking.oal.rt.parser;
 
-import lombok.AllArgsConstructor;
+import java.util.LinkedList;
+import java.util.List;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
 
 @Getter
 @Setter
 @NoArgsConstructor
-@AllArgsConstructor
 public class ConditionExpression {
     // original from script
     private String expressionType;
     private String attribute;
     private String value;
+

Review comment:
       I think this empty line is not required.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org