[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on a change in pull request #171: Fix-305: Checkbox replaces with Icons for proportionality field in Edit payroll Screen

[GitBox <gi...@apache.org>]

PatelVatsalB21 commented on a change in pull request #171:
URL: https://github.com/apache/fineract-cn-mobile/pull/171#discussion_r599432772



##########
File path: app/src/main/java/org/apache/fineract/ui/adapters/PayrollAllocationAdapter.kt
##########
@@ -28,7 +29,13 @@ class PayrollAllocationAdapter @Inject constructor()
         val (accountNumber, amount, proportional) = payrollAllocation[position]
         holder.tvAccount.text = accountNumber
         holder.tvAmount.text = amount.toString()
-        holder.cbProportional.isChecked = proportional
+        if (proportional) {
+            holder.ivproportional_checked.visibility = View.VISIBLE
+            holder.ivproportional_crossed.visibility= View.GONE
+        }else {

Review comment:
       @varsvat have you locally checked code with `.\gradlew check --scan`. If not I think it will fail **checkstyle** due to no space between else and `}` this brace.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org