You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "HonahX (via GitHub)" <gi...@apache.org> on 2023/08/26 00:54:44 UTC
[GitHub] [iceberg] HonahX opened a new pull request, #8396: Doc: Reflect Apache HttpClient as Default in AWS Integration Page
HonahX opened a new pull request, #8396:
URL: https://github.com/apache/iceberg/pull/8396
Fixes: #8296
In #7199, the default http client of AWS is switched from `url-connection` to `apache`. This PR update part of the doc to reflect the change.
cc: @singhpk234 @jackye1995 @stevenzwu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #8396: Doc: Reflect Apache HttpClient as Default in AWS Integration Page
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #8396:
URL: https://github.com/apache/iceberg/pull/8396#issuecomment-1698323064
Thanks for reviewing @singhpk234 , merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar merged pull request #8396: Doc: Reflect Apache HttpClient as Default in AWS Integration Page
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #8396:
URL: https://github.com/apache/iceberg/pull/8396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] HonahX commented on a diff in pull request #8396: Doc: Reflect Apache HttpClient as Default in AWS Integration Page
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #8396:
URL: https://github.com/apache/iceberg/pull/8396#discussion_r1308182032
##########
docs/aws.md:
##########
@@ -31,16 +31,16 @@ This section describes how to use Iceberg with AWS.
## Enabling AWS Integration
-The `iceberg-aws` module is bundled with Spark and Flink engine runtimes for all versions from `0.11.0` onwards.
+The `iceberg-aws` module is bundled with Spark and Flink engine runtimes for all versions from `0.11.0` onwards.ƒ
Review Comment:
oops. Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #8396: Doc: Reflect Apache HttpClient as Default in AWS Integration Page
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #8396:
URL: https://github.com/apache/iceberg/pull/8396#discussion_r1308076492
##########
docs/aws.md:
##########
@@ -31,16 +31,16 @@ This section describes how to use Iceberg with AWS.
## Enabling AWS Integration
-The `iceberg-aws` module is bundled with Spark and Flink engine runtimes for all versions from `0.11.0` onwards.
+The `iceberg-aws` module is bundled with Spark and Flink engine runtimes for all versions from `0.11.0` onwards.ƒ
Review Comment:
Could you remove the `f` at the end of the line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org