You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RyukR1 (via GitHub)" <gi...@apache.org> on 2026/06/23 12:30:53 UTC
[PR] Refactor Snowflake provider tests to remove legacy unittest imports [airflow]
RyukR1 opened a new pull request, #68898:
URL: https://github.com/apache/airflow/pull/68898
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
This PR refactors the test file for the Snowflake SQL API hook to fully align with Airflow's pytest migration guidelines.
Specifically, it:
- Removes the unused `import unittest` statement
- Cleans up legacy references from `unittest.mock.patch.dict` to `mock.patch.dict` (since `from unittest import mock` is already imported)
### Modified Files:
- `providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py`
---
### Tests Run
We executed the Snowflake provider tests inside Breeze:
```bash
breeze run pytest providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py -xvs
```
---
Result: All 70 tests passed successfully.
<!--
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ X] Yes — Antigravity (Gemini 3.5 Flash)
Generated-by: Antigravity (Gemini 3.5 Flash) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
<!--
Generated-by: Antigravity (Gemini 3.5 Flash) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor Snowflake provider tests to remove legacy unittest imports [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #68898:
URL: https://github.com/apache/airflow/pull/68898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org