You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/12 20:51:16 UTC

[GitHub] [netbeans] mbien commented on a diff in pull request #4106: upgrade nb-javac to 18.0.1.

mbien commented on code in PR #4106:
URL: https://github.com/apache/netbeans/pull/4106#discussion_r871798984


##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps:
##########
@@ -40,8 +40,8 @@ nbbuild/external/langtools-9.zip nbbuild/external/langtools-9.zip
 nbbuild/external/json-simple-1.1.1.jar ide/libs.json_simple/external/json-simple-1.1.1.jar
 
 # Compile only nb-javac
-java/libs.nbjavacapi/external/nb-javac-jdk-18+36-api.jar nbbuild/external/nb-javac-jdk-17+36-api.jar
-java/libs.nbjavacapi/external/nb-javac-jdk-18+36.jar nbbuild/external/nb-javac-jdk-17+36.jar
+java/libs.nbjavacapi/external/nb-javac-jdk-18.0.1+10-api.jar nbbuild/external/nb-javac-jdk-17+36-api.jar
+java/libs.nbjavacapi/external/nb-javac-jdk-18.0.1+10.jar nbbuild/external/nb-javac-jdk-17+36.jar

Review Comment:
   btw why is here JDK 17+36 listed? I didn't really check what this file does, i only replaced 18+36 with 18.0.1+10.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists