You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/21 09:36:03 UTC

[GitHub] [incubator-superset] chuancyzhang opened a new pull request #10377: fix: Pivot Table can't display Null value

chuancyzhang opened a new pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377


   substitute NULL_STRING in PivotTableViz Class for any nulls in the necessary columns
   
   ### SUMMARY
   substitute NULL_STRING in PivotTableViz Class for any nulls in the necessary columns
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [x ] Changes UI
   - [x ] Requires DB Migration.
   - [ x] Confirm DB Migration upgrade and downgrade tested.
   - [ x] Introduces new feature or API
   - [ x] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] chuancyzhang commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-662855614


   @villebro Today, we fix some bug, more precisely fill Null String in Dataframe. Please review this PR and merge it first. Because I am not sure whether my modifications in other classes are correct. refer New PR[#10390](https://github.com/apache/incubator-superset/pull/10390)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661809281


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=h1) Report
   > Merging [#10377](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3c39b26c994f8110ad0f686140ff050fad3f91bc&el=desc) will **increase** coverage by `4.24%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10377/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10377      +/-   ##
   ==========================================
   + Coverage   65.46%   69.70%   +4.24%     
   ==========================================
     Files         603      196     -407     
     Lines       32436    19019   -13417     
     Branches     3297        0    -3297     
   ==========================================
   - Hits        21234    13258    -7976     
   + Misses      11018     5761    -5257     
   + Partials      184        0     -184     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `69.70% <0.00%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.04% <0.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `58.62% <0.00%> (-3.96%)` | :arrow_down: |
   | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `91.12% <0.00%> (-1.62%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.83% <0.00%> (-0.84%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.29% <0.00%> (-0.25%)` | :arrow_down: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `93.54% <0.00%> (-0.21%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.34% <0.00%> (-0.15%)` | :arrow_down: |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.95% <0.00%> (-0.08%)` | :arrow_down: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.30% <0.00%> (-0.01%)` | :arrow_down: |
   | ... and [413 more](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=footer). Last update [3c39b26...cb5a3b8](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro edited a comment on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661780781


   On second thought, you can probably also use the `fill_value` parameter in `pivot_table`, it might be more performant. See: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.pivot_table.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661780781


   On second thought, you can probably also use the `fill_value` argument in `pivot_table`, it might be more performant. See: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.pivot_table.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661788615


   Ok, thanks for trying. It seems CI flaked out, I'll restart.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] closed pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] chuancyzhang commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-662318963


   > It's not better to handle this like `DistribuationBarViz` handled this?
   > And do this for other classes
   > https://github.com/apache/incubator-superset/blob/9b8da402955d3adcebaf7b711b79e0cfd720d025/superset/viz.py#L1624-L1627
   
   please review this PR[#10390](https://github.com/apache/incubator-superset/pull/10390). we have been tested in our development.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] stale[bot] commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-703188916


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661809281


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=h1) Report
   > Merging [#10377](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3c39b26c994f8110ad0f686140ff050fad3f91bc&el=desc) will **increase** coverage by `4.99%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10377/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10377      +/-   ##
   ==========================================
   + Coverage   65.46%   70.46%   +4.99%     
   ==========================================
     Files         603      603              
     Lines       32436    32437       +1     
     Branches     3297     3297              
   ==========================================
   + Hits        21234    22856    +1622     
   + Misses      11018     9475    -1543     
   + Partials      184      106      -78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.39% <ø> (?)` | |
   | #javascript | `59.36% <ø> (ø)` | |
   | #python | `69.78% <0.00%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.04% <0.00%> (ø)` | |
   | [...src/components/FilterableTable/FilterableTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS50c3g=) | `81.77% <0.00%> (-0.41%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.35% <0.00%> (+0.43%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <0.00%> (+1.42%)` | :arrow_up: |
   | [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `74.62% <0.00%> (+1.49%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `98.31% <0.00%> (+1.68%)` | :arrow_up: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `78.84% <0.00%> (+1.92%)` | :arrow_up: |
   | ... and [148 more](https://codecov.io/gh/apache/incubator-superset/pull/10377/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=footer). Last update [3c39b26...9161536](https://codecov.io/gh/apache/incubator-superset/pull/10377?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] chuancyzhang commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661790493


   > Ok, thanks for trying. It seems CI flaked out, I'll restart.
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] chuancyzhang commented on pull request #10377: fix: Pivot Table can't display Null value

Posted by GitBox <gi...@apache.org>.
chuancyzhang commented on pull request #10377:
URL: https://github.com/apache/incubator-superset/pull/10377#issuecomment-661787748


   > On second thought, you can probably also use the `fill_value` parameter in `pivot_table`, it might be more performant. See: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.pivot_table.html
   
   I try to use fill_value slove this bug, but fail it. it's same error.
   ![image](https://user-images.githubusercontent.com/23111194/88047482-48757400-cb84-11ea-99d6-9b46aae54b36.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org