You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/01/25 02:42:37 UTC

[GitHub] [hadoop] cndaimin commented on a change in pull request #3881: HDFS-16422. Fix thread safety of EC decoding during concurrent preads

cndaimin commented on a change in pull request #3881:
URL: https://github.com/apache/hadoop/pull/3881#discussion_r791312508



##########
File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java
##########
@@ -432,7 +432,9 @@ void decodeAndFillBuffer(boolean fillBuffer) throws IOException {
 
     long start = Time.monotonicNow();
     // Step 2: decode into prepared output buffers
-    decoder.decode(decodeInputs, decodeIndices, outputs);
+    synchronized (decoder) {

Review comment:
       Thanks for your review. @jojochuang 
   Yes, that's better. I will update it in a few minutes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org