You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by an...@apache.org on 2008/02/11 20:38:53 UTC
svn commit: r620588 - in /tapestry/tapestry4/trunk/tapestry-framework/src:
java/org/apache/tapestry/form/DefaultOptionRenderer.java
test/org/apache/tapestry/form/TestPropertySelection.java
Author: andyhot
Date: Mon Feb 11 11:38:52 2008
New Revision: 620588
URL: http://svn.apache.org/viewvc?rev=620588&view=rev
Log:
TAPESTRY-2091: Have disabled options render disabled="disabled"
Modified:
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/DefaultOptionRenderer.java
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestPropertySelection.java
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/DefaultOptionRenderer.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/DefaultOptionRenderer.java?rev=620588&r1=620587&r2=620588&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/DefaultOptionRenderer.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/DefaultOptionRenderer.java Mon Feb 11 11:38:52 2008
@@ -55,7 +55,7 @@
}
if (model.isDisabled(i))
- writer.attribute("disabled", "true");
+ writer.attribute("disabled", "disabled");
writer.print(model.getLabel(i));
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestPropertySelection.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestPropertySelection.java?rev=620588&r1=620587&r2=620588&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestPropertySelection.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestPropertySelection.java Mon Feb 11 11:38:52 2008
@@ -133,7 +133,7 @@
assertBuffer("<span class=\"prefix\"><select name=\"hannah\" id=\"hannah\" class=\"validation-delegate\">" + SYSTEM_NEWLINE +
"<option value=\"0\" selected=\"selected\">One</option>" + SYSTEM_NEWLINE +
"<option value=\"1\">Two</option>" + SYSTEM_NEWLINE +
- "<option value=\"2\" disabled=\"true\">Three</option>" + SYSTEM_NEWLINE +
+ "<option value=\"2\" disabled=\"disabled\">Three</option>" + SYSTEM_NEWLINE +
"</select></span>");
}
}