You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/11/19 14:17:37 UTC
Review Request 69395: Added '--all' flag to 'mesos task list'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399
Repository: mesos
Description
-------
With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.
Diffs
-----
src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
Diff: https://reviews.apache.org/r/69395/diff/1/
Testing
-------
```
(mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 8 tests in 20.889s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------
(Updated Nov. 22, 2018, 12:36 p.m.)
Review request for .
Changes
-------
Rebased to fix issue.
Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399
Repository: mesos
Description
-------
With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
Diff: https://reviews.apache.org/r/69395/diff/2/
Changes: https://reviews.apache.org/r/69395/diff/1-2/
Testing
-------
```
(mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 8 tests in 20.889s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210846
-----------------------------------------------------------
PASS: Mesos patch 69395 was successfully built and tested.
Reviews applied: `['69394', '69425', '69426', '69395']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2644/mesos-review-69395
- Mesos Reviewbot Windows
On Nov. 25, 2018, 7:17 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2018, 7:17 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 4abc70a2de7e63bb629d5ed82d0045b29fb237fa
> src/python/cli_new/lib/cli/tests/task.py 1b48c0a4729043c874330552074b05368e38b715
>
>
> Diff: https://reviews.apache.org/r/69395/diff/3/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210867
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2647/mesos-review-69395
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2647/mesos-review-69395/logs/mesos-tests.log):
```
I1126 14:58:10.665406 54324 executor.cpp:918] Sending SIGTERM to process tree at pid 55c1-4ff9-bcc4-79f65eb49d86-0000 because it is terminating
I1126 14:58:10.666405 59016 master.cpp:1275] Agent 8c178cd5-55c1-4ff9-bcc4-79f65eb49d86-S0 at slave(461)@192.10.1.5:59448 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I1126 14:58:10.667402 59016 master.cpp:3273] Disconnecting agent 8c178cd5-55c1-4ff9-bcc4-79f65eb49d86-S0 at slave(461)@192.10.1.5:59448 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1126 14:58:10.667402 59016 master.cpp:3292] Deactivating agent 8c178cd5-55c1-4ff9-bcc4-79f65eb49d86-S0 at slave(461)@192.10.1.5:59448 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I1126 14:58:10.667402 46364 hierarchical.cpp:357] Removed framework 8c178cd5-55c1-4ff9-bcc4-79f65eb49d86-0000
I1126 14:58:10.667402 46364 hierarchical.cpp:801] Agent 8c178cd5-55c1-4ff9-bcc4-79f65eb49d86-S0 deactivated
I1126 14:58:10.668414 59016 containerizer.cpp:2463] Destroying container 9b953b62-5d06-4378-96ea-a3dbd15d5aaa in RUNNING state
I1126 14:58:10.668414[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (795 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (816 ms total)
[----------] Global test environment tear-down
[==========] 1054 tests from 103 test cases ran. (509518 ms total)
[ PASSED ] 1053 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
1 FAILED TEST
YOU HAVE 231 DISABLED TESTS
59016 containerizer.cpp:3130] Transitioning the state of container 9b953b62-5d06-4378-96ea-a3dbd15d5aaa from RUNNING to DESTROYING
I1126 14:58:10.669421 59016 launcher.cpp:161] Asked to destroy container 9b953b62-5d06-4378-96ea-a3dbd15d5aaa
W1126 14:58:10.670413 58692 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11784 to peer '192.10.1.5:61260': IO failed with error code: The specified network name is no longer available.
W1126 14:58:10.671396 58692 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=11720 to peer '192.10.1.5:61261': IO failed with error code: The specified network name is no longer available.
I1126 14:58:10.759449 60456 containerizer.cpp:2969] Container 9b953b62-5d06-4378-96ea-a3dbd15d5aaa has exited
I1126 14:58:10.797418 60904 master.cpp:1117] Master terminating
I1126 14:58:10.799414 59016 hierarchical.cpp:643] Removed agent 8c178cd5-55c1-4ff9-bcc4-79f65eb49d86-S0
I1126 14:58:11.723407 58692 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Nov. 26, 2018, 1:54 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 1:54 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f
> src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5
>
>
> Diff: https://reviews.apache.org/r/69395/diff/5/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210866
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Nov. 26, 2018, 1:54 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 1:54 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f
> src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5
>
>
> Diff: https://reviews.apache.org/r/69395/diff/5/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------
(Updated Nov. 26, 2018, 2:54 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Fixed issues.
Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399
Repository: mesos
Description
-------
With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f
src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5
Diff: https://reviews.apache.org/r/69395/diff/5/
Changes: https://reviews.apache.org/r/69395/diff/4-5/
Testing
-------
```
(mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 8 tests in 20.889s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210864
-----------------------------------------------------------
src/python/cli_new/lib/cli/tests/task.py
Lines 250 (patched)
<https://reviews.apache.org/r/69395/#comment295665>
Can we be more descriptive here?
src/python/cli_new/lib/cli/tests/task.py
Lines 252 (patched)
<https://reviews.apache.org/r/69395/#comment295666>
Comment should mention launching two tasks or something.
- Kevin Klues
On Nov. 26, 2018, 1:51 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2018, 1:51 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f
> src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5
>
>
> Diff: https://reviews.apache.org/r/69395/diff/4/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------
(Updated Nov. 26, 2018, 2:51 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399
Repository: mesos
Description
-------
With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py 0ce21b365d64c5c331ce7f1a5937258960e15b6f
src/python/cli_new/lib/cli/tests/task.py eb01bf5cae095a067572f534a13f4ec542101ca5
Diff: https://reviews.apache.org/r/69395/diff/4/
Changes: https://reviews.apache.org/r/69395/diff/3-4/
Testing
-------
```
(mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 8 tests in 20.889s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------
(Updated Nov. 25, 2018, 12:17 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Fixed issues.
Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399
Repository: mesos
Description
-------
With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py 4abc70a2de7e63bb629d5ed82d0045b29fb237fa
src/python/cli_new/lib/cli/tests/task.py 1b48c0a4729043c874330552074b05368e38b715
Diff: https://reviews.apache.org/r/69395/diff/3/
Changes: https://reviews.apache.org/r/69395/diff/2-3/
Testing
-------
```
(mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 8 tests in 20.889s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210814
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 69394.
Failed command: `python.exe .\support\apply-reviews.py -n -r 69394`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2637/mesos-review-69395
Relevant logs:
- [apply-review-69394.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2637/mesos-review-69395/logs/apply-review-69394.log):
```
error: patch failed: src/python/cli_new/lib/cli/plugins/task/main.py:126
error: src/python/cli_new/lib/cli/plugins/task/main.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/task.py:186
error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 22, 2018, 11:36 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 11:36 a.m.)
>
>
> Review request for Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
> src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
>
>
> Diff: https://reviews.apache.org/r/69395/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210790
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 69395`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2636/mesos-review-69395
Relevant logs:
- [apply-review-69395.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2636/mesos-review-69395/logs/apply-review-69395.log):
```
error: patch failed: src/python/cli_new/lib/cli/plugins/task/main.py:60
error: src/python/cli_new/lib/cli/plugins/task/main.py: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 22, 2018, 12:36 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 12:36 p.m.)
>
>
> Review request for .
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
> src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
>
>
> Diff: https://reviews.apache.org/r/69395/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210815
-----------------------------------------------------------
Bad patch!
Reviews applied: [69395, 69426, 69425, 69394, 69393]
Failed command: /usr/bin/python3 support/apply-reviews.py -n -r 69394
Error:
2018-11-22 17:30:19 URL:https://reviews.apache.org/r/69394/diff/raw/ [2592/2592] -> "69394.patch" [1]
error: patch failed: src/python/cli_new/lib/cli/plugins/task/main.py:126
error: src/python/cli_new/lib/cli/plugins/task/main.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/task.py:186
error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/23570/console
- Mesos Reviewbot
On Nov. 22, 2018, 11:36 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 11:36 a.m.)
>
>
> Review request for Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
> src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
>
>
> Diff: https://reviews.apache.org/r/69395/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210812
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Nov. 22, 2018, 11:36 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2018, 11:36 a.m.)
>
>
> Review request for .
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
> src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
>
>
> Diff: https://reviews.apache.org/r/69395/diff/2/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/
-----------------------------------------------------------
(Updated Nov. 22, 2018, 12:36 p.m.)
Review request for .
Changes
-------
Rebased to fix issue.
Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399
Repository: mesos
Description
-------
With this option, the command can show all the tasks that have ever been
run. This makes the command's behavior closer to the one of 'docker ps'.
Diffs (updated)
-----
src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
Diff: https://reviews.apache.org/r/69395/diff/2/
Changes: https://reviews.apache.org/r/69395/diff/1-2/
Testing
-------
```
(mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests
TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok
TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok
test_list_all (cli.tests.task.TestTaskPlugin) ... ok
----------------------------------------------------------------------
Ran 8 tests in 20.889s
OK
```
Thanks,
Armand Grillet
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210662
-----------------------------------------------------------
src/python/cli_new/lib/cli/tests/task.py
Lines 238 (patched)
<https://reviews.apache.org/r/69395/#comment295387>
This will be flakey.
- Kevin Klues
On Nov. 19, 2018, 2:17 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2018, 2:17 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
> src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
>
>
> Diff: https://reviews.apache.org/r/69395/diff/1/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 69395: Added '--all' flag to 'mesos task list'.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69395/#review210656
-----------------------------------------------------------
PASS: Mesos patch 69395 was successfully built and tested.
Reviews applied: `['69393', '69394', '69395']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2621/mesos-review-69395
- Mesos Reviewbot Windows
On Nov. 19, 2018, 2:17 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69395/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2018, 2:17 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With this option, the command can show all the tasks that have ever been
> run. This makes the command's behavior closer to the one of 'docker ps'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 0536ccb29551400ce59713017c86eb5e858aeb5f
> src/python/cli_new/lib/cli/tests/task.py f033b4a7663279c8a7c49ed86b3acdda45ceb107
>
>
> Diff: https://reviews.apache.org/r/69395/diff/1/
>
>
> Testing
> -------
>
> ```
> (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_list_all (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 20.889s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>