You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Meredith (JIRA)" <ji...@apache.org> on 2019/08/13 17:19:00 UTC

[jira] [Commented] (CASSANDRA-15272) Enhance & reenable RepairTest

    [ https://issues.apache.org/jira/browse/CASSANDRA-15272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906419#comment-16906419 ] 

Jon Meredith commented on CASSANDRA-15272:
------------------------------------------

+1 from me.

It's probably worth waiting until CASSANDRA-15170 lands first and it'll only need a minor tweak to change GOSSIP/NETWORK import path.

Only one nit, instead of commenting out the compressed test, what do you think about using @Ignore instead

{{@Ignore("test requires CASSANDRA-13938 to be merged")}}

That gives somebody looking at the output from test runners a better chance of noticing it is disabled for a reason and enabling in future.

> Enhance & reenable RepairTest
> -----------------------------
>
>                 Key: CASSANDRA-15272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Consistency/Repair
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Normal
>
> Currently the In-JVM RepairTest is not enabled on trunk (See for more info: CASSANDRA-13938). This patch enables the In JVM RepairTest. It adds a new test that tests the compression=off path for SSTables. It will help catch any regressions in repair on this path. This does not fix the issue with the compressed sstable streaming (CASSANDRA-13938). That should be addressed in the original ticket.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org