[jira] [Commented] (CALCITE-4787) Move core to use Immutables instead of ImmutableBeans

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616963#comment-17616963 ] 

Stamatis Zampetakis commented on CALCITE-4787:
----------------------------------------------

This change along with CALCITE-4830 adds a significant burden to the configuration of some rules. Unless I missed something, the extensibility of PruneEmptyRules seems to be somewhat broken (see CALCITE-5332). I am afraid that except the pruning rules the change may have affected other rules as wells. I will discuss potential fixes under CALCITE-5332 but just wanted to give a heads up here since many people follow this ticket.

> Move core to use Immutables instead of ImmutableBeans
> -----------------------------------------------------
>
>                 Key: CALCITE-4787
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4787
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Jacques Nadeau
>            Assignee: Jacques Nadeau
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>          Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> In the creation of CALCITE-3328, [Immutables|https://immutables.github.io/] was discussed as an alternative to a custom implementation. This ticket is to evaluate the impact to the codebase of changing. Ideally, introduction of immutables would both add flexibility and reduce the amount of code associated with these classes.
> Immutables works via annotation processor which means that it is should be relatively seamless to build systems and IDEs.
> The switch would also make it easier to work with these objects types in the context of aot compilation tools like GraalVM.
>  
> This initial task covers key classes in the core module. Will open up follow-on tickets for other locations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)