You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/01/31 21:00:47 UTC
Review Request 65442: Made `ns::setns` overloads consistent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65442/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Only the path-based overload of `ns::setns` accepted the
`checkMultithreaded` flag. For API consistency, we now also
accept this flag in the PID-based overload.
Diffs
-----
src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
src/linux/ns.cpp 446640705b7c060776ed87655fb17509865cd335
Diff: https://reviews.apache.org/r/65442/diff/1/
Testing
-------
make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 65442: Made `ns::setns` overloads consistent.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65442/#review196596
-----------------------------------------------------------
PASS: Mesos patch 65442 was successfully built and tested.
Reviews applied: `['65442']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65442
- Mesos Reviewbot Windows
On Jan. 31, 2018, 1 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65442/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 1 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only the path-based overload of `ns::setns` accepted the
> `checkMultithreaded` flag. For API consistency, we now also
> accept this flag in the PID-based overload.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 446640705b7c060776ed87655fb17509865cd335
>
>
> Diff: https://reviews.apache.org/r/65442/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 65442: Made `ns::setns` overloads consistent.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65442/#review196594
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 31, 2018, 9 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65442/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 9 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only the path-based overload of `ns::setns` accepted the
> `checkMultithreaded` flag. For API consistency, we now also
> accept this flag in the PID-based overload.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91
> src/linux/ns.cpp 446640705b7c060776ed87655fb17509865cd335
>
>
> Diff: https://reviews.apache.org/r/65442/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>