[GitHub] [camel-website] zregvart commented on a diff in pull request #998: Added support for tabs in asciidoc files

["zregvart (via GitHub)" <gi...@apache.org>]

zregvart commented on code in PR #998:
URL: https://github.com/apache/camel-website/pull/998#discussion_r1178827278


##########
package.json:
##########
@@ -35,6 +35,7 @@
   "devDependencies": {
     "@antora/cli": "^3.0.0",
     "@antora/site-generator": "^3.0.0",
+    "@asciidoctor/tabs": "1.0.0-beta.3",

Review Comment:
   I don't think we need it here, only in the UI



##########
antora-ui-camel/public/_/partials/head-styles.hbs:
##########
@@ -1 +1,2 @@
-    <link rel="stylesheet" href="{{uiRootPath}}/css/site-00b7d111da.css">
+    <link rel="stylesheet" href="{{uiRootPath}}/css/site-66db361433.css">
+    <link rel="stylesheet" href="{{{uiRootPath}}}/css/tabs.css">

Review Comment:
   I don't think this is needed, `tabs.css` is included in the `site-*.css`



##########
antora-ui-camel/src/css/site.css:
##########
@@ -29,3 +29,4 @@
 @import 'catalog.css';
 @import 'sharingbuttons.css';
 @import 'security.css';
+@import 'tabs.css'

Review Comment:
   Try this instead, so we don't need to copy `tabs.css` from @asciidoctor/tabs
   ```suggestion
   @import '@asciidoctor/tabs/dist/css/tabs.css'
   ```



##########
antora-ui-camel/src/css/tabs.css:
##########
@@ -0,0 +1,98 @@
+/*! Asciidoctor Tabs | Copyright (c) 2018-present Dan Allen | MIT License */

Review Comment:
   Let's use `@import '@asciidoctor/tabs/...` from above so we don't need to vendor this file, keeping it here makes it prone to being stale when we upgrade the @asciidoctor/tabs dependency



##########
antora-ui-camel/src/partials/head-styles.hbs:
##########
@@ -1 +1,2 @@
     <link rel="stylesheet" href="{{uiRootPath}}/css/site.css">
+    <link rel="stylesheet" href="{{{uiRootPath}}}/css/tabs.css">

Review Comment:
   Should be included in the `site.css`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org