You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/05/14 12:17:37 UTC
Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing
dhcp leases.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
Bugs: cloudstack-6665
https://issues.apache.org/jira/browse/cloudstack-6665
Repository: cloudstack-git
Description
-------
The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
Diffs
-----
systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh 70c95a8
Diff: https://reviews.apache.org/r/21431/diff/
Testing
-------
Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
Thanks,
Joris van Lieshout
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by John Nielsen <jo...@betterservers.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review43260
-----------------------------------------------------------
I was just about to post something similar, thanks for reporting. Below I propose a slightly more reliable way to extract the interface name from the "ip route" output:
$(ip route get 10.0.0.117 | grep " dev " | sed -e "s/^.* dev \([^ ]*\) .*$/\1/g")
- John Nielsen
On May 14, 2014, 1:58 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 1:58 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh 70c95a8
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by Daan Hoogland <da...@gmail.com>.
Marcus, I will but Joris is considering John Nielsen's
comment. It is on 4.4-forward and will be in by the end of the week I
think. 4.3 is open territory I think, isn't it?
regards,
Daan
On Mon, May 19, 2014 at 7:45 PM, Marcus Sorensen <sh...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
>
> On May 14th, 2014, 2:12 p.m. UTC, *daan Hoogland* wrote:
>
> 2ebeec43340f33e2a00553b171452c6516ccc946 on master
>
> We should consider cherry-picking this for 4.3/4.4 as well
>
>
> - Marcus
>
> On May 14th, 2014, 1:58 p.m. UTC, Joris van Lieshout wrote:
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng
> Yang.
> By Joris van Lieshout.
>
> *Updated May 14, 2014, 1:58 p.m.*
> *Bugs: * cloudstack-6665<https://issues.apache.org/jira/browse/cloudstack-6665>
> *Repository: * cloudstack-git
> Description
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
> Testing
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
> Diffs
>
> - systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh (70c95a8)
>
> View Diff <https://reviews.apache.org/r/21431/diff/>
>
--
Daan
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by Marcus Sorensen <sh...@gmail.com>.
> On May 14, 2014, 2:12 p.m., daan Hoogland wrote:
> > 2ebeec43340f33e2a00553b171452c6516ccc946 on master
We should consider cherry-picking this for 4.3/4.4 as well
- Marcus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review42959
-----------------------------------------------------------
On May 14, 2014, 1:58 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 1:58 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh 70c95a8
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review42959
-----------------------------------------------------------
2ebeec43340f33e2a00553b171452c6516ccc946 on master
- daan Hoogland
On May 14, 2014, 1:58 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 14, 2014, 1:58 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh 70c95a8
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review47191
-----------------------------------------------------------
Commit 0e50cb1246f762e9d1f0ece937395ffb193c6452 in cloudstack's branch refs/heads/4.3 from Joris van Lieshout
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0e50cb1 ]
CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
Author: John Nielsen <jo...@betterservers.com>
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
- ASF Subversion and Git Services
On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:05 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review47190
-----------------------------------------------------------
Commit 6d0650bbcd26a7147857548c5f20949d2c986f76 in cloudstack's branch refs/heads/4.3 from Joris van Lieshout
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6d0650b ]
CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.
Signed-off-by: Sebastien Goasguen <ru...@gmail.com>
- ASF Subversion and Git Services
On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:05 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review43470
-----------------------------------------------------------
Ship it!
applied both versions 2 and 3 of the patch to 4.4:
1c88ea51e54cc13f460512258531058552debea9 and 8326428bb86d3cd80c8984a74c8513ca86e1ba80
should have asked for a new patch, sorry
- daan Hoogland
On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:05 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review47059
-----------------------------------------------------------
CLOUDSTACK-6665 says this is a problem in 4.3, but this patch only applies to 4.4.
Could you provide a patch for 4.3 ?
thanks
- Sebastien Goasguen
On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 9:05 a.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
>
>
> Bugs: cloudstack-6665
> https://issues.apache.org/jira/browse/cloudstack-6665
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6
>
> Diff: https://reviews.apache.org/r/21431/diff/
>
>
> Testing
> -------
>
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/
-----------------------------------------------------------
(Updated May 20, 2014, 9:05 a.m.)
Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
Changes
-------
Thanks John, you are right. That is a better way. I assumed that the device would always be an eth interface. Your solution is more flexible on that part. I've created a new patch with your improvement.
Bugs: cloudstack-6665
https://issues.apache.org/jira/browse/cloudstack-6665
Repository: cloudstack-git
Description
-------
The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
Diffs (updated)
-----
systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6
Diff: https://reviews.apache.org/r/21431/diff/
Testing
-------
Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
Thanks,
Joris van Lieshout
Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not
releasing dhcp leases.
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/
-----------------------------------------------------------
(Updated May 14, 2014, 1:58 p.m.)
Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
Changes
-------
Sorry for the wrong patch format at first.
Bugs: cloudstack-6665
https://issues.apache.org/jira/browse/cloudstack-6665
Repository: cloudstack-git
Description
-------
The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
Diffs (updated)
-----
systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh 70c95a8
Diff: https://reviews.apache.org/r/21431/diff/
Testing
-------
Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
Thanks,
Joris van Lieshout