You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/18 16:06:04 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new pull request #1540: Add ArangoDB component extension fixes #1533
zbendhiba opened a new pull request #1540:
URL: https://github.com/apache/camel-quarkus/pull/1540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1540: Add ArangoDB component extension fixes #1533
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1540:
URL: https://github.com/apache/camel-quarkus/pull/1540#discussion_r472376666
##########
File path: extensions/arangodb/runtime/pom.xml
##########
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-arangodb-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-arangodb</artifactId>
+ <name>Camel Quarkus :: ArangoDb :: Runtime</name>
+ <description>Perform operations on ArangoDb documents, collections and graphs.</description>
+
+ <properties>
+ <firstVersion>1.0.0-CR4</firstVersion>
Review comment:
```suggestion
<firstVersion>1.1.0</firstVersion>
```
You probably generated the modules before 1.0.0. If you did it now, you'd get the currently correct firstVersion 1.1.0
After changing this, please rebase (the structure of the docs changed a bit) and run `mvn process-resources -Pformat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #1540: Add ArangoDB component extension fixes #1533
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #1540:
URL: https://github.com/apache/camel-quarkus/pull/1540#discussion_r472778972
##########
File path: extensions/arangodb/runtime/pom.xml
##########
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-arangodb-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-arangodb</artifactId>
+ <name>Camel Quarkus :: ArangoDb :: Runtime</name>
+ <description>Perform operations on ArangoDb documents, collections and graphs.</description>
+
+ <properties>
+ <firstVersion>1.0.0-CR4</firstVersion>
Review comment:
done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1540: Add ArangoDB component extension fixes #1533
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1540:
URL: https://github.com/apache/camel-quarkus/pull/1540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1540: Add ArangoDB component extension fixes #1533
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1540:
URL: https://github.com/apache/camel-quarkus/pull/1540#discussion_r472824597
##########
File path: extensions/arangodb/runtime/pom.xml
##########
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-arangodb-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-arangodb</artifactId>
+ <name>Camel Quarkus :: ArangoDb :: Runtime</name>
+ <description>Perform operations on ArangoDb documents, collections and graphs.</description>
+
+ <properties>
+ <firstVersion>1.0.0-CR4</firstVersion>
Review comment:
> rebase (the structure of the docs changed a bit)
Sorry, I was wrong about this, I have not noticed that this PR was against `camel-master`. `camel-master` is yet to be reabased on top of `master` to get those changes. I'd say let's merge this and let the `camel-master` maintainer deal with the rebase conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org