Re: [PR] CASSANDRA-15452: Read Ahead for Compaction, Repair, and Range Queries [cassandra]

["jrwest (via GitHub)" <gi...@apache.org>]

jrwest commented on code in PR #3606:
URL: https://github.com/apache/cassandra/pull/3606#discussion_r1976731608


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -934,6 +934,9 @@ else if (conf.max_value_size.toMebibytes() >= 2048)
                 break;
         }
 
+        if (conf.compressed_read_ahead_buffer_size.toKibibytes() > 0 && conf.compressed_read_ahead_buffer_size.toKibibytes() < 256)

Review Comment:
   We're making sure the buffer is not smaller than 256k as the benefits are rather low otherwise. But i am not necessarily opposed to lowering the lower limit if there is a case for it @Maxwell-Guo 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org