You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2023/06/23 14:53:19 UTC
[GitHub] [daffodil-vscode] shanedell opened a new pull request, #677: Launch Wizard updates based on 1.3.0-rc3 issues
shanedell opened a new pull request, #677:
URL: https://github.com/apache/daffodil-vscode/pull/677
Launch Wizard updates based on 1.3.0-rc3 issues:
- Update daffodil debug classpath items CSS to make the items height and width match the content.
- Make launch wizard always available. Before was only available whenever not debugging.
- Fix issue with tdml config throw errors if action was not set.
- infosetOutput bug fixed, was defaulting to type console when it was supposed to file.
Closes #672
Closes #674
Closes #675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell merged pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] nlewis05 commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "nlewis05 (via GitHub)" <gi...@apache.org>.
nlewis05 commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1240046396
##########
package.json:
##########
@@ -345,7 +344,7 @@
"type": "object",
"description": "Destination for final Infoset ('file' | 'console' | 'none')",
"default": {
- "type": "console",
+ "type": "file",
"path": "${workspaceFolder}/infoset.xml"
Review Comment:
Yes, I am unable to select individual files when using the file picker, I just get to the directory that contains them, I thought this was intended behavior so did not think it was a bug. I get to this point and if i want a jar in this folder, i simply hit the button in the bottom right and hope that its added properly. This is being done on a Rocky 9 Vagrant box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#issuecomment-1609550651
@scholarsmate @arosien @stricklandrbls Can you give this a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1240005281
##########
package.json:
##########
@@ -345,7 +344,7 @@
"type": "object",
"description": "Destination for final Infoset ('file' | 'console' | 'none')",
"default": {
- "type": "console",
+ "type": "file",
"path": "${workspaceFolder}/infoset.xml"
Review Comment:
The default location for this shoudl be "${workspaceFolder}/target/infoset.xml" so that it doesn't clutter and end up committed by accident.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1242192695
##########
package.json:
##########
@@ -345,7 +344,7 @@
"type": "object",
"description": "Destination for final Infoset ('file' | 'console' | 'none')",
"default": {
- "type": "console",
+ "type": "file",
"path": "${workspaceFolder}/infoset.xml"
Review Comment:
@mbeckerle So after getting my ubuntu VM up and running I am able to get the same issue as you and @nlewis05 when it comes to picking out single JARs. It seems the VSCode API is limiting Linux so that you have to specify that the user can pick files OR folders and doesn't allow both. One way to get around it is when you open the file picker for the JARs bring up a selection box where you chose `Single File` or `Directory` before going to the file picker, this allow for us to set up the file picker properly. Or can you think of another, possibly better, way to get around it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1242452783
##########
package.json:
##########
@@ -345,7 +344,7 @@
"type": "object",
"description": "Destination for final Infoset ('file' | 'console' | 'none')",
"default": {
- "type": "console",
+ "type": "file",
"path": "${workspaceFolder}/infoset.xml"
Review Comment:
Or maybe instead of having only the `Browse` button we make two buttons. One `Add Folder(s)` and one `Add File(s)` and then how is how the code will know how to show the file picker. I think this would be nicer then the other option I stated above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1240010121
##########
package.json:
##########
@@ -345,7 +344,7 @@
"type": "object",
"description": "Destination for final Infoset ('file' | 'console' | 'none')",
"default": {
- "type": "console",
+ "type": "file",
"path": "${workspaceFolder}/infoset.xml"
Review Comment:
gotcha I like this idea. I am also still looking into the selecting a single JAR issue. It is working for me on Mac but you said it doesn't work for you (which I believe you use Linux) and believe @nlewis05 mentioned he saw that as well, possibly failing on windows as well. So I am currently getting up Linux VM up and running to get this fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1242473166
##########
package.json:
##########
@@ -345,7 +344,7 @@
"type": "object",
"description": "Destination for final Infoset ('file' | 'console' | 'none')",
"default": {
- "type": "console",
+ "type": "file",
"path": "${workspaceFolder}/infoset.xml"
Review Comment:
@mbeckerle @nlewis05 Please give this another look over. I made the daffodilDebugClasspath have two buttons like mentioned above to fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org