You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2002/05/30 03:12:34 UTC
DO NOT REPLY [Bug 9511] New: -
Object instantiation optimization in StandardSession.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9511>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9511
Object instantiation optimization in StandardSession.java
Summary: Object instantiation optimization in
StandardSession.java
Product: Tomcat 4
Version: 4.1.2
Platform: All
OS/Version: All
Status: NEW
Severity: Enhancement
Priority: Other
Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: dlr@finemaltcoding.com
This minor optimization saves a couple of object instantiations by using
constants when writing objects to an output stream. This change likely also
applies to the 4.0.x branch.
Index: StandardSession.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/cata\lina/session/StandardSession.java,v
retrieving revision 1.28
diff -u -u -r1.28 StandardSession.java
--- StandardSession.java 1 Mar 2002 19:37:45 -0000 1.28
+++ StandardSession.java 30 May 2002 01:09:09 -0000
@@ -1400,8 +1400,8 @@
stream.writeObject(new Long(creationTime));
stream.writeObject(new Long(lastAccessedTime));
stream.writeObject(new Integer(maxInactiveInterval));
- stream.writeObject(new Boolean(isNew));
- stream.writeObject(new Boolean(isValid));
+ stream.writeObject(isNew ? Boolean.TRUE : Boolean.FALSE);
+ stream.writeObject(isValid ? Boolean.TRUE : Boolean.FALSE);
stream.writeObject(new Long(thisAccessedTime));
stream.writeObject(id);
if (debug >= 2)
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>