You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2012/08/03 08:01:30 UTC
Review Request: This patch includes the preliminary documentation draft for
the defect fixes and new features: site-to-site vpn and inter-vlan routing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6328/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
This patch includes the preliminary documentation draft for the defect fixes and new features: site-to-site vpn and inter-vlan routing.
Diffs
-----
docs/en-US/Book_Info.xml 6ff42f2
docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION
docs/en-US/add-tier.xml PRE-CREATION
docs/en-US/add-vm-to-tier.xml PRE-CREATION
docs/en-US/admin-guide.xml c10455d
docs/en-US/change-ssvm-service-offering.xml PRE-CREATION
docs/en-US/compatibility-matrix.xml ac8e838
docs/en-US/configure-acl.xml PRE-CREATION
docs/en-US/configure-vpc.xml PRE-CREATION
docs/en-US/create-vpn-customer-gateway.xml PRE-CREATION
docs/en-US/create-vpn-gateway-for-vpc.xml PRE-CREATION
docs/en-US/create-vr-network-offering.xml PRE-CREATION
docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION
docs/en-US/enable-disable-static-nat.xml 0895b88
docs/en-US/inter-vlan-routing.xml PRE-CREATION
docs/en-US/release-ip-for-vpc.xml PRE-CREATION
docs/en-US/release-notes-3.0.4.xml 21f47c6
docs/en-US/site-to-site-vpn.xml 2e29909
docs/en-US/upgrade-management-server.xml PRE-CREATION
docs/en-US/using-sshkeys.xml a753b32
docs/en-US/vpc.xml cd298a1
Diff: https://reviews.apache.org/r/6328/diff/
Testing
-------
Thanks,
Radhika PC
Re: Review Request: This patch includes the preliminary documentation draft
for the defect fixes and new features: site-to-site vpn and inter-vlan
routing.
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6328/#review9808
-----------------------------------------------------------
Radhika - the License Headers have come off of some of the XMLs. Could you please resend with the Licenses intact?
- Prasanna Santhanam
On Aug. 3, 2012, 6:01 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6328/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 6:01 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This patch includes the preliminary documentation draft for the defect fixes and new features: site-to-site vpn and inter-vlan routing.
>
>
> Diffs
> -----
>
> docs/en-US/Book_Info.xml 6ff42f2
> docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION
> docs/en-US/add-tier.xml PRE-CREATION
> docs/en-US/add-vm-to-tier.xml PRE-CREATION
> docs/en-US/admin-guide.xml c10455d
> docs/en-US/change-ssvm-service-offering.xml PRE-CREATION
> docs/en-US/compatibility-matrix.xml ac8e838
> docs/en-US/configure-acl.xml PRE-CREATION
> docs/en-US/configure-vpc.xml PRE-CREATION
> docs/en-US/create-vpn-customer-gateway.xml PRE-CREATION
> docs/en-US/create-vpn-gateway-for-vpc.xml PRE-CREATION
> docs/en-US/create-vr-network-offering.xml PRE-CREATION
> docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION
> docs/en-US/enable-disable-static-nat.xml 0895b88
> docs/en-US/inter-vlan-routing.xml PRE-CREATION
> docs/en-US/release-ip-for-vpc.xml PRE-CREATION
> docs/en-US/release-notes-3.0.4.xml 21f47c6
> docs/en-US/site-to-site-vpn.xml 2e29909
> docs/en-US/upgrade-management-server.xml PRE-CREATION
> docs/en-US/using-sshkeys.xml a753b32
> docs/en-US/vpc.xml cd298a1
>
> Diff: https://reviews.apache.org/r/6328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: This patch includes the preliminary documentation draft
for the defect fixes and new features: site-to-site vpn and inter-vlan
routing.
Posted by Jessica Tomechak <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6328/#review10832
-----------------------------------------------------------
Ship it!
Ship It!
- Jessica Tomechak
On Aug. 3, 2012, 6:01 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6328/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 6:01 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This patch includes the preliminary documentation draft for the defect fixes and new features: site-to-site vpn and inter-vlan routing.
>
>
> Diffs
> -----
>
> docs/en-US/Book_Info.xml 6ff42f2
> docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION
> docs/en-US/add-tier.xml PRE-CREATION
> docs/en-US/add-vm-to-tier.xml PRE-CREATION
> docs/en-US/admin-guide.xml c10455d
> docs/en-US/change-ssvm-service-offering.xml PRE-CREATION
> docs/en-US/compatibility-matrix.xml ac8e838
> docs/en-US/configure-acl.xml PRE-CREATION
> docs/en-US/configure-vpc.xml PRE-CREATION
> docs/en-US/create-vpn-customer-gateway.xml PRE-CREATION
> docs/en-US/create-vpn-gateway-for-vpc.xml PRE-CREATION
> docs/en-US/create-vr-network-offering.xml PRE-CREATION
> docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION
> docs/en-US/enable-disable-static-nat.xml 0895b88
> docs/en-US/inter-vlan-routing.xml PRE-CREATION
> docs/en-US/release-ip-for-vpc.xml PRE-CREATION
> docs/en-US/release-notes-3.0.4.xml 21f47c6
> docs/en-US/site-to-site-vpn.xml 2e29909
> docs/en-US/upgrade-management-server.xml PRE-CREATION
> docs/en-US/using-sshkeys.xml a753b32
> docs/en-US/vpc.xml cd298a1
>
> Diff: https://reviews.apache.org/r/6328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: This patch includes the preliminary documentation draft
for the defect fixes and new features: site-to-site vpn and inter-vlan
routing.
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6328/#review9815
-----------------------------------------------------------
I looked at a few more that might need fixing.
1> All the .xml should have ASF license header.
2> DOCTYPE header references the DTD at file:///C:/Program%20Files%20(x86)/Publican/DocBook_DTD/docbookx.dtd instead of "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
3> &PRODUCT; entity to be used where branding is done (Apache CloudStack). Should not have references to CloudPlatform.
4> The document still references CloudPlatform in most places. You should use the &entity there as well?
5> I see a reference to CloudStack 3.0.4. CloudStack has not had a 3.0.4 release. Should these be 4.0 perhaps?
Let me know if you need any help fixing these. I can fix 1> and 2>.
- Prasanna Santhanam
On Aug. 3, 2012, 6:01 a.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6328/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2012, 6:01 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> This patch includes the preliminary documentation draft for the defect fixes and new features: site-to-site vpn and inter-vlan routing.
>
>
> Diffs
> -----
>
> docs/en-US/Book_Info.xml 6ff42f2
> docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION
> docs/en-US/add-tier.xml PRE-CREATION
> docs/en-US/add-vm-to-tier.xml PRE-CREATION
> docs/en-US/admin-guide.xml c10455d
> docs/en-US/change-ssvm-service-offering.xml PRE-CREATION
> docs/en-US/compatibility-matrix.xml ac8e838
> docs/en-US/configure-acl.xml PRE-CREATION
> docs/en-US/configure-vpc.xml PRE-CREATION
> docs/en-US/create-vpn-customer-gateway.xml PRE-CREATION
> docs/en-US/create-vpn-gateway-for-vpc.xml PRE-CREATION
> docs/en-US/create-vr-network-offering.xml PRE-CREATION
> docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION
> docs/en-US/enable-disable-static-nat.xml 0895b88
> docs/en-US/inter-vlan-routing.xml PRE-CREATION
> docs/en-US/release-ip-for-vpc.xml PRE-CREATION
> docs/en-US/release-notes-3.0.4.xml 21f47c6
> docs/en-US/site-to-site-vpn.xml 2e29909
> docs/en-US/upgrade-management-server.xml PRE-CREATION
> docs/en-US/using-sshkeys.xml a753b32
> docs/en-US/vpc.xml cd298a1
>
> Diff: https://reviews.apache.org/r/6328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: This patch includes the preliminary documentation draft
for the defect fixes and new features: site-to-site vpn and inter-vlan
routing.
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6328/
-----------------------------------------------------------
(Updated Aug. 3, 2012, 6:01 a.m.)
Review request for cloudstack.
Description
-------
This patch includes the preliminary documentation draft for the defect fixes and new features: site-to-site vpn and inter-vlan routing.
Diffs
-----
docs/en-US/Book_Info.xml 6ff42f2
docs/en-US/acquire-new-ip-for-vpc.xml PRE-CREATION
docs/en-US/add-tier.xml PRE-CREATION
docs/en-US/add-vm-to-tier.xml PRE-CREATION
docs/en-US/admin-guide.xml c10455d
docs/en-US/change-ssvm-service-offering.xml PRE-CREATION
docs/en-US/compatibility-matrix.xml ac8e838
docs/en-US/configure-acl.xml PRE-CREATION
docs/en-US/configure-vpc.xml PRE-CREATION
docs/en-US/create-vpn-customer-gateway.xml PRE-CREATION
docs/en-US/create-vpn-gateway-for-vpc.xml PRE-CREATION
docs/en-US/create-vr-network-offering.xml PRE-CREATION
docs/en-US/enable-disable-static-nat-vpc.xml PRE-CREATION
docs/en-US/enable-disable-static-nat.xml 0895b88
docs/en-US/inter-vlan-routing.xml PRE-CREATION
docs/en-US/release-ip-for-vpc.xml PRE-CREATION
docs/en-US/release-notes-3.0.4.xml 21f47c6
docs/en-US/site-to-site-vpn.xml 2e29909
docs/en-US/upgrade-management-server.xml PRE-CREATION
docs/en-US/using-sshkeys.xml a753b32
docs/en-US/vpc.xml cd298a1
Diff: https://reviews.apache.org/r/6328/diff/
Testing
-------
Thanks,
Radhika PC