You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:23:54 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests
HyukjinKwon commented on a change in pull request #28689:
URL: https://github.com/apache/spark/pull/28689#discussion_r433080460
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/Utils.scala
##########
@@ -131,4 +133,9 @@ object Utils extends Logging {
s"under spark home test dir ${sparkHomeDir.toAbsolutePath}!")
}
}
+
+ def isHadoop3(): Boolean = {
Review comment:
Out of curiosity, can we `org.apache.hadoop.util.VersionInfo`? e.g.) `VersionInfo.getVersion.startsWith("3")`. At least I know this is being used in Apache Spark codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org