You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2025/03/03 11:55:58 UTC

[Impala-ASF-CR] IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes

Peter Rozsa has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/22423 )

Change subject: IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes
......................................................................

IMPALA-13674: Enable MERGE statement for Iceberg tables with equality deletes

This change fixes the delete expression calculation for
IcebergMergeImpl, when an Iceberg table contains equality deletes, the
merge implementation now includes the data sequence number in the result
expressions as the underlying tuple descriptor also includes it
implicitly. Without including this field, the row evaluation fails
because of the mismatching number of evaluators and slot descriptors.

Tests:
 - manually validated on an Iceberg table that contains equality delete
 - e2e test added

Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1
---
M be/src/exec/iceberg-merge-node.cc
M be/src/exec/iceberg-merge-node.h
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M fe/src/main/java/org/apache/impala/planner/IcebergMergeNode.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeModifyStmtsTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-equality-insert.test
A testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-equality-update.test
M tests/common/file_utils.py
M tests/query_test/test_iceberg.py
M tests/util/iceberg_metadata_util.py
11 files changed, 128 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/22423/8
-- 
To view, visit http://gerrit.cloudera.org:8080/22423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60e48e2731a59520373dbb75104d75aae39a94c1
Gerrit-Change-Number: 22423
Gerrit-PatchSet: 8
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>