[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1125: HDDS-3866. Support multi-part-upload with Freon S3 key generator

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #1125:
URL: https://github.com/apache/hadoop-ozone/pull/1125#discussion_r445299473



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/S3KeyGenerator.java
##########
@@ -54,7 +64,8 @@
   private String bucketName;
 
   @Option(names = {"-s", "--size"},
-      description = "Size of the generated key (in bytes)",
+      description = "Size of the generated key (in bytes) or size of one "
+          + "multipart upload part (in case of multipart upload)",

Review comment:
       Minor: Do you think we need some check on the size, when multipart upload option is specified, as in MPU each part should be at least 5MB(except last part) But here we use same part size having that check would be useful, otherwise we shall get an error during complete MPU afteer uploading 10 parts.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org