[jira] [Commented] (ARTEMIS-873) Use K,M,G notations on broker.xml

["Jeff Mesnil (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861493#comment-15861493 ] 

Jeff Mesnil commented on ARTEMIS-873:
-------------------------------------

I think this (great) RFE should be updated to fix the names and amounts of the multiples.

In the code 1GB is set to 1 * 1024 * 1024 but that is wrong. 1GB is 1 * 1000 * 1000 bytes.
The correct binary notation would be 1GiB (see https://en.wikipedia.org/wiki/Gibibyte).

I understand that most people use kB/MB/GB instead of KiB/MiB/GiB but Artemis should support both notations so that the amount will always be computed correctly.

> Use K,M,G notations on broker.xml
> ---------------------------------
>
>                 Key: ARTEMIS-873
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-873
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 1.5.2
>            Reporter: Fábio Gomes dos Santos
>            Assignee: Justin Bertram
>             Fix For: 2.0.0, 1.5.3
>
>
> Many keys in broker.xml need the value in bytes.
> To make this easy we can use 1G instead 1073741824.
> It is a small feature but very useful
> Example:
> global-max-size only support the bytes notation... 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)