[GitHub] [airflow] ashb commented on a diff in pull request #26457: Add user comment to task instance and dag run

[GitBox <gi...@apache.org>]

ashb commented on code in PR #26457:
URL: https://github.com/apache/airflow/pull/26457#discussion_r1032704684


##########
airflow/www/static/js/api/useDatasetEvents.ts:
##########
@@ -30,7 +30,7 @@ export default function useDatasetEvents({
   const query = useQuery(
     ['datasets-events', datasetId, sourceDagId, sourceRunId, sourceTaskId, sourceMapIndex, limit, offset, orderBy],
     () => {
-      const datasetsUrl = getMetaValue('dataset_events_api') || '/api/v1/datasets/events';
+      const datasetsUrl = getMetaValue('dataset_events_api');

Review Comment:
   Turns out that the grid.html was missing this value.
   
   And due to how `getMetaValue` currently behaves (it just returns an empty string!) this just showed up as "no dataset events" instead.
   
   Temporary fix https://github.com/apache/airflow/pull/27927 but we should go and make getMetaValue error if the requested tag isn't found (but lets do that _after_ 2.5.)
   
   @Jorricks For future: please try to keep entirely unrelated changes like this to a separate PR (this change has 0 to do with notes.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org