You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/02/11 23:52:18 UTC

[GitHub] [zeppelin] Leemoonsoo commented on pull request #4054: [ZEPPELIN-5248] - Add local docker-compose support and updated readme instructions

Leemoonsoo commented on pull request #4054:
URL: https://github.com/apache/zeppelin/pull/4054#issuecomment-777872855


   Thank @omrisk for the contribution!
   
   I tested this on
   
   ![image](https://user-images.githubusercontent.com/1540981/107713077-5b19dc80-6c7f-11eb-9f70-85c30f941c5e.png)
   (I had to change the 'version' field of 'docker-compose.yml' from '3.8' to '3.3' in this docker version. After the change, worked well without problem)
   
   as well as with the latest Docker engine
   ![image](https://user-images.githubusercontent.com/1540981/107713479-2eb29000-6c80-11eb-9271-e49d9fcb4a90.png)
   
   @omrisk Looks like [rat plugin fails](https://github.com/apache/zeppelin/pull/4054/checks?check_run_id=1879669313) due to missing license header on docker-compose.yml file. Could you try to add a license header? (e.g. https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml#L1-L16)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org