You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/11 12:11:56 UTC

[GitHub] [incubator-mxnet] xidulu edited a comment on issue #17272: [Numpy] Add infra for performing constraint check

xidulu edited a comment on issue #17272: [Numpy] Add infra for performing constraint check
URL: https://github.com/apache/incubator-mxnet/pull/17272#issuecomment-573311442
 
 
   > Could you improve the documentation to clarify how to ensure that the constraint check is executed?
   
   @leezu 
   I add some brief explanation and a toy example to demonstrate how this OP work in the doc section.
   https://github.com/apache/incubator-mxnet/pull/17272/files#diff-23804c433abe5a6ae5c3a113425d3df8R60
   
   ------------------------
   Unfortunately, I cannot provide further technical details regarding why this `hack` could work, cuz I don't have know much about the computation graph engine.
   But according to my test cases, this implementation could now do what it is designed to do.
   https://github.com/apache/incubator-mxnet/pull/17272/files#diff-ccbb8554206b519fd0d562d679aadfdcR3145
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services