You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/08 12:07:37 UTC

[GitHub] [flink] xuyangzhong opened a new pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

xuyangzhong opened a new pull request #17436:
URL: https://github.com/apache/flink/pull/17436


   ## What is the purpose of the change
   
   This pull request mainly helps give users clearer exception messages when the divisor is zero. Before, 1.0e0 / 0.0e0 will be computed to infinity and when converting it to decimal, throws exception "Infinite or NaN". Now we follow the SQL Standard: throw "Division by zero".
   
   ## Brief change log
   
     - add validate function in ExpressionReducer.
     - add a rule in ExpressionTestBase to fire the expression reducer.
     - change some existing test cases.
     - add some test cases to verify this change.
   
   
   ## Verifying this change
   
   Some test cases have been added to verify this change.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5d0f5029884cd1df7cee4b455952122fce5046ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893) 
   * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891) 
   * 5d0f5029884cd1df7cee4b455952122fce5046ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xuyangzhong commented on a change in pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on a change in pull request #17436:
URL: https://github.com/apache/flink/pull/17436#discussion_r732509497



##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -1116,6 +1117,29 @@ class TemporalTypesTest extends ExpressionTestBase {
       "1437699600")
   }
 
+  /**
+   * now Flink only support TIMESTAMP(3) as the return type in TO_TIMESTAMP
+   * See: https://issues.apache.org/jira/browse/FLINK-14925
+   */
+  @Test
+  def testToTimeStampFunctionWithHighPrecision(): Unit = {
+    testSqlApi(
+      "TO_TIMESTAMP('1970-01-01 00:00:00.123456789')",
+      "1970-01-01 00:00:00.123")
+
+    testSqlApi(
+      "TO_TIMESTAMP('1970-01-01 00:00:00.12345', 'yyyy-MM-dd HH:mm:ss.SSSSS')",
+      "1970-01-01 00:00:00.123")
+
+    testSqlApi(
+      "TO_TIMESTAMP('20000202 59:59.1234567', 'yyyyMMdd mm:ss.SSSSSSS')",
+      "2000-02-02 00:59:59.123")
+
+    testSqlApi(
+      "TO_TIMESTAMP('1234567', 'SSSSSSS')",
+      "1970-01-01 00:00:00.123")
+  }
+
   @Test
   def testHighPrecisionTimestamp(): Unit = {
     // EXTRACT should support millisecond/microsecond/nanosecond

Review comment:
       These test cases will fail because an extra rule "CoreRules.PROJECT_REDUCE_EXPRESSIONS" is added into the test builder. And the new rule will truncate the timestamp(n) to timestamp(3). (see https://issues.apache.org/jira/browse/FLINK-14925). In actual Flink sql, these test cases will also fail. So I think this is unreasonable and we should keep TIMESTAMP(3) now.(Flink now supports)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5d0f5029884cd1df7cee4b455952122fce5046ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893) 
   * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295",
       "triggerID" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295",
       "triggerID" : "948346629",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * c4fd4fc12dddf7d9a37bf111429158d158f32b2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262) 
   * c4fd4fc12dddf7d9a37bf111429158d158f32b2c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5d0f5029884cd1df7cee4b455952122fce5046ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891) 
   * 5d0f5029884cd1df7cee4b455952122fce5046ed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17436:
URL: https://github.com/apache/flink/pull/17436#discussion_r732537456



##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala
##########
@@ -1116,6 +1117,29 @@ class TemporalTypesTest extends ExpressionTestBase {
       "1437699600")
   }
 
+  /**
+   * now Flink only support TIMESTAMP(3) as the return type in TO_TIMESTAMP
+   * See: https://issues.apache.org/jira/browse/FLINK-14925
+   */
+  @Test
+  def testToTimeStampFunctionWithHighPrecision(): Unit = {
+    testSqlApi(
+      "TO_TIMESTAMP('1970-01-01 00:00:00.123456789')",
+      "1970-01-01 00:00:00.123")
+
+    testSqlApi(
+      "TO_TIMESTAMP('1970-01-01 00:00:00.12345', 'yyyy-MM-dd HH:mm:ss.SSSSS')",
+      "1970-01-01 00:00:00.123")
+
+    testSqlApi(
+      "TO_TIMESTAMP('20000202 59:59.1234567', 'yyyyMMdd mm:ss.SSSSSSS')",
+      "2000-02-02 00:59:59.123")
+
+    testSqlApi(
+      "TO_TIMESTAMP('1234567', 'SSSSSSS')",
+      "1970-01-01 00:00:00.123")
+  }
+
   @Test
   def testHighPrecisionTimestamp(): Unit = {
     // EXTRACT should support millisecond/microsecond/nanosecond

Review comment:
       make sense, thanks for the explanation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe closed pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #17436:
URL: https://github.com/apache/flink/pull/17436


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xuyangzhong commented on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-939236099


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295",
       "triggerID" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4fd4fc12dddf7d9a37bf111429158d158f32b2c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on a change in pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #17436:
URL: https://github.com/apache/flink/pull/17436#discussion_r732541865



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExpressionReducer.scala
##########
@@ -254,6 +233,59 @@ class ExpressionReducer(
       targetType,
       true)
   }
+
+  /**
+   * skip the expressions that can't be reduced now
+   * and validate the expressions
+   */
+  private def skipAndValidateExprs(
+      rexBuilder: RexBuilder,
+      constExprs: java.util.List[RexNode],
+      pythonUDFExprs: ListBuffer[RexNode]): List[RexNode] ={
+    constExprs.asScala.map(e => (e.getType.getSqlTypeName, e)).flatMap {
+
+      // Skip expressions that contain python functions because it's quite expensive to
+      // call Python UDFs during optimization phase. They will be optimized during the runtime.
+      case (_, e) if containsPythonCall(e) =>
+        pythonUDFExprs += e
+        None
+
+      // we don't support object literals yet, we skip those constant expressions
+      case (SqlTypeName.ANY, _) |
+           (SqlTypeName.OTHER, _) |
+           (SqlTypeName.ROW, _) |
+           (SqlTypeName.STRUCTURED, _) |
+           (SqlTypeName.ARRAY, _) |
+           (SqlTypeName.MAP, _) |
+           (SqlTypeName.MULTISET, _) => None
+
+      case (_, call: RexCall) => {
+        // Exclude some JSON functions which behave differently
+        // when called as an argument of another call of one of these functions.
+        if (nonReducibleJsonFunctions.contains(call.getOperator)) {
+          None

Review comment:
       should add `return`, otherwise it will return `Some(call)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] xuyangzhong commented on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-948346629


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295",
       "triggerID" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295",
       "triggerID" : "948346629",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * c4fd4fc12dddf7d9a37bf111429158d158f32b2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987][tabel-planner]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262",
       "triggerID" : "8e7cadf33f0414a07b1496cabe0c8d7088f870c2",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295",
       "triggerID" : "c4fd4fc12dddf7d9a37bf111429158d158f32b2c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8e7cadf33f0414a07b1496cabe0c8d7088f870c2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25262) 
   * c4fd4fc12dddf7d9a37bf111429158d158f32b2c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25295) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938592665


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d14a0793a2628a8c9bd778ccbee95e7419f15346 (Fri Oct 08 12:11:45 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15987).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #17436: [FLINK-15987]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17436:
URL: https://github.com/apache/flink/pull/17436#issuecomment-938641830


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857",
       "triggerID" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d14a0793a2628a8c9bd778ccbee95e7419f15346",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891",
       "triggerID" : "939236099",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893",
       "triggerID" : "5d0f5029884cd1df7cee4b455952122fce5046ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d14a0793a2628a8c9bd778ccbee95e7419f15346 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24857) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24891) 
   * 5d0f5029884cd1df7cee4b455952122fce5046ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24893) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org