You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Greg Lucas (JIRA)" <ji...@apache.org> on 2009/08/19 19:21:14 UTC

[jira] Created: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

OdeSUManager produces component-task-result strings that are not fully compliant. 
----------------------------------------------------------------------------------

                 Key: ODE-653
                 URL: https://issues.apache.org/jira/browse/ODE-653
             Project: ODE
          Issue Type: Bug
          Components: JBI Integration
    Affects Versions: 1.3.3
            Reporter: Greg Lucas
            Priority: Minor


The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.

The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 

ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 

(Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Lucas updated ODE-653:
---------------------------

    Attachment: ODE-653-1.x-patch2.txt

Fixed the patch, tested with FUSE 3.4.0.4 as well. 

> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: ODE-653-1.x-patch.txt, ODE-653-1.x-patch2.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757976#action_12757976 ] 

Alex Boisvert commented on ODE-653:
-----------------------------------

Applied to trunk as well,

boisvert@sixtine:~/svn/ode/trunk$ svn commit -m "ODE-653: OdeSUManager produces component-task-result strings that are not fully compliant (2nd patch)"
Sending        jbi/src/main/java/org/apache/ode/jbi/OdeSUManager.java
Transmitting file data .
Committed revision 817356.


> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: ODE-653-1.x-patch.txt, ODE-653-1.x-patch2.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Lucas reopened ODE-653:
----------------------------


Reopening this issue, the patch does not work with FUSE 3.4:

Starting Apache ServiceMix ESB: 3.4.0.4-fuse
>
> Loading Apache ServiceMix from servicemix.xml on the CLASSPATH
> [Fatal Error] :2:140: Attribute "xmlns" bound to namespace  
> "http://www.w3.org/2000/xmlns/" was already specified for element  
> "component-task-result".
> [Fatal Error] :2:140: Attribute "xmlns" bound to namespace  
> "http://www.w3.org/2000/xmlns/" was already specified for element  
> "component-task-result".
> [Fatal Error] :2:140: Attribute "xmlns" bound to namespace  
> "http://www.w3.org/2000/xmlns/" was already specified for element  
> "component-task-result".
> [Fatal Error] :2:140: Attribute "xmlns" bound to namespace  
> "http://www.w3.org/2000/xmlns/" was already specified for element  
> "component-task-result".

> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: ODE-653-1.x-patch.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved ODE-653.
-------------------------------

    Resolution: Fixed

Applied 2nd patch.

boisvert@sixtine:~/svn/ode/1.1$ svn commit -m "ODE-653: OdeSUManager produces component-task-result strings that are not fully compliant (2nd patch)"
Sending        jbi/src/main/java/org/apache/ode/jbi/OdeSUManager.java
Transmitting file data .
Committed revision 817355.


> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: ODE-653-1.x-patch.txt, ODE-653-1.x-patch2.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved ODE-653.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.4

Patch applied to 1.x branch and trunk.  Thanks!

boisvert@sixtine:~/svn/ode/1.1$ svn commit -m "ODE-653: OdeSUManager produces component-task-result strings that are not fully compliant (courtesy of Greg Lucas)"
Sending        jbi/src/main/java/org/apache/ode/jbi/OdeSUManager.java
Transmitting file data .
Committed revision 805931.

boisvert@sixtine:~/svn/ode/trunk$ svn commit -m "ODE-653: OdeSUManager produces component-task-result strings that are not fully compliant (courtesy of Greg Lucas)"
Sending        jbi/src/main/java/org/apache/ode/jbi/OdeSUManager.java
Transmitting file data .
Committed revision 805932.


> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: ODE-653-1.x-patch.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Greg Lucas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Greg Lucas updated ODE-653:
---------------------------

    Attachment: ODE-653-1.x-patch.txt

Patch for the 1.x branch to use the JBI namespace when producing a component-task-result.

> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>         Attachments: ODE-653-1.x-patch.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ODE-653) OdeSUManager produces component-task-result strings that are not fully compliant.

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ODE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745504#action_12745504 ] 

Alex Boisvert commented on ODE-653:
-----------------------------------

Rolled back the previous changes,

boisvert@sixtine:~/svn/ode/1.1$ svn commit -m "Rollback changeset r805931; ODE-653: OdeSUManager produces component-task-result strings that are not fully compliant"
Sending        jbi/src/main/java/org/apache/ode/jbi/OdeSUManager.java
Transmitting file data .
Committed revision 806257.

boisvert@sixtine:~/svn/ode/trunk$ svn commit -m "Rollback changeset r805932; ODE-653: OdeSUManager produces component-task-result strings that are not fully compliant"
Sending        jbi/src/main/java/org/apache/ode/jbi/OdeSUManager.java
Transmitting file data .
Committed revision 806260.


> OdeSUManager produces component-task-result strings that are not fully compliant. 
> ----------------------------------------------------------------------------------
>
>                 Key: ODE-653
>                 URL: https://issues.apache.org/jira/browse/ODE-653
>             Project: ODE
>          Issue Type: Bug
>          Components: JBI Integration
>    Affects Versions: 1.3.3
>            Reporter: Greg Lucas
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: ODE-653-1.x-patch.txt
>
>
> The JBI spec specifies that a ServiceUnitMnager must return an XML string of the component-task-result for the deploy/undeploy methods. The component-task-result must conform to the http://java.sun.com/xml/ns/jbi/management-message schema.
> The OdeSUManager currently returns component-task-result strings that do not declare the namespace, so parsing these strings produces an XML document that does actually conform to the schema in the spec. 
> ServiceMix will treat these result strings as invalid and ignore them. I've submitted an SMX4 patch to handle the case where no namespace is declared, but think that ODE should fully conform to the spec regardless of whether that patch gets applied. 
> (Note that the ServiceUnitManager javadoc is a bit misleading as the example it shows has the xmlns declaration on the wrong node. I think the text of the JBI spec is more authoritative and would consider the example in the javadoc incorrect as well. The ODE result string doesn't match the example either.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.