You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sebastien Goasguen <ru...@gmail.com> on 2012/11/27 10:19:50 UTC
Review Request: Fix for CLOUDSTACK-547
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8233/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Fixing https://issues.apache.org/jira/browse/CLOUDSTACK-547 , multiple instances of CloudPlatform in docs
This addresses bug 547.
Diffs
-----
docs/en-US/add-clusters-ovm.xml 11e1a13
docs/en-US/admin-guide.xml 512f7a9
docs/en-US/aws-ec2-configuration.xml b8966c1
docs/en-US/basic-zone-configuration.xml e27c914
docs/en-US/basic-zone-guest-ip-addresses.xml d1d9135
docs/en-US/basic-zone-physical-network-configuration.xml 83833a7
docs/en-US/best-practices-primary-storage.xml 2f639b1
docs/en-US/best-practices-secondary-storage.xml c2da7d8
docs/en-US/cloudplatform-api.xml 3c4a914
docs/en-US/configuring-projects.xml 0f84dd8
docs/en-US/log-in-root-admin.xml bf499d6
docs/en-US/manual-live-migration.xml 30a5c11
docs/en-US/network-offerings.xml ccfb93c
docs/en-US/network-service-providers.xml af57097
docs/en-US/port-forwarding.xml b778693
docs/en-US/primary-storage.xml 4cefa83
docs/en-US/query-filter.xml fa5ea63
docs/en-US/release-ip-address.xml 87b5300
docs/en-US/roles.xml 473e37b
docs/en-US/troubleshooting-lb-rules-fails.xml c507178
docs/en-US/troubleshooting-maintenance-mode-not-working-on-vCenter.xml c4bf37f
docs/en-US/using-swift-for-secondary-storage.xml bf238ca
docs/en-US/vm-lifecycle.xml f5696ce
Diff: https://reviews.apache.org/r/8233/diff/
Testing
-------
Thanks,
Sebastien Goasguen
Re: Review Request: Fix for CLOUDSTACK-547
Posted by Gavin Lee <ga...@gmail.com>.
> On Nov. 27, 2012, 3 p.m., Gavin Lee wrote:
> > Ship It!
I'll apply the patch tomorrow morning.
Please close it as submitted.
Thanks.
- Gavin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8233/#review13775
-----------------------------------------------------------
On Nov. 27, 2012, 9:19 a.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8233/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 9:19 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixing https://issues.apache.org/jira/browse/CLOUDSTACK-547 , multiple instances of CloudPlatform in docs
>
>
> This addresses bug 547.
>
>
> Diffs
> -----
>
> docs/en-US/add-clusters-ovm.xml 11e1a13
> docs/en-US/admin-guide.xml 512f7a9
> docs/en-US/aws-ec2-configuration.xml b8966c1
> docs/en-US/basic-zone-configuration.xml e27c914
> docs/en-US/basic-zone-guest-ip-addresses.xml d1d9135
> docs/en-US/basic-zone-physical-network-configuration.xml 83833a7
> docs/en-US/best-practices-primary-storage.xml 2f639b1
> docs/en-US/best-practices-secondary-storage.xml c2da7d8
> docs/en-US/cloudplatform-api.xml 3c4a914
> docs/en-US/configuring-projects.xml 0f84dd8
> docs/en-US/log-in-root-admin.xml bf499d6
> docs/en-US/manual-live-migration.xml 30a5c11
> docs/en-US/network-offerings.xml ccfb93c
> docs/en-US/network-service-providers.xml af57097
> docs/en-US/port-forwarding.xml b778693
> docs/en-US/primary-storage.xml 4cefa83
> docs/en-US/query-filter.xml fa5ea63
> docs/en-US/release-ip-address.xml 87b5300
> docs/en-US/roles.xml 473e37b
> docs/en-US/troubleshooting-lb-rules-fails.xml c507178
> docs/en-US/troubleshooting-maintenance-mode-not-working-on-vCenter.xml c4bf37f
> docs/en-US/using-swift-for-secondary-storage.xml bf238ca
> docs/en-US/vm-lifecycle.xml f5696ce
>
> Diff: https://reviews.apache.org/r/8233/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastien Goasguen
>
>
Re: Review Request: Fix for CLOUDSTACK-547
Posted by Gavin Lee <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8233/#review13775
-----------------------------------------------------------
Ship it!
Ship It!
- Gavin Lee
On Nov. 27, 2012, 9:19 a.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8233/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 9:19 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixing https://issues.apache.org/jira/browse/CLOUDSTACK-547 , multiple instances of CloudPlatform in docs
>
>
> This addresses bug 547.
>
>
> Diffs
> -----
>
> docs/en-US/add-clusters-ovm.xml 11e1a13
> docs/en-US/admin-guide.xml 512f7a9
> docs/en-US/aws-ec2-configuration.xml b8966c1
> docs/en-US/basic-zone-configuration.xml e27c914
> docs/en-US/basic-zone-guest-ip-addresses.xml d1d9135
> docs/en-US/basic-zone-physical-network-configuration.xml 83833a7
> docs/en-US/best-practices-primary-storage.xml 2f639b1
> docs/en-US/best-practices-secondary-storage.xml c2da7d8
> docs/en-US/cloudplatform-api.xml 3c4a914
> docs/en-US/configuring-projects.xml 0f84dd8
> docs/en-US/log-in-root-admin.xml bf499d6
> docs/en-US/manual-live-migration.xml 30a5c11
> docs/en-US/network-offerings.xml ccfb93c
> docs/en-US/network-service-providers.xml af57097
> docs/en-US/port-forwarding.xml b778693
> docs/en-US/primary-storage.xml 4cefa83
> docs/en-US/query-filter.xml fa5ea63
> docs/en-US/release-ip-address.xml 87b5300
> docs/en-US/roles.xml 473e37b
> docs/en-US/troubleshooting-lb-rules-fails.xml c507178
> docs/en-US/troubleshooting-maintenance-mode-not-working-on-vCenter.xml c4bf37f
> docs/en-US/using-swift-for-secondary-storage.xml bf238ca
> docs/en-US/vm-lifecycle.xml f5696ce
>
> Diff: https://reviews.apache.org/r/8233/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastien Goasguen
>
>
Re: Review Request: Fix for CLOUDSTACK-547
Posted by Sebastien Goasguen <ru...@gmail.com>.
> On Nov. 27, 2012, 2:35 p.m., Gavin Lee wrote:
> > Hi, Sebastien
> > Thanks for the patch! I tested and it passed publican build for publican-adminguide.cfg.
> > Only one question, the file cloudplatform-api.xml should be renamed to cloudstack-api.xml rather than deleted. Could you please help to check this?
> >
> > Thanks again.
Yes you are correct. I deleted it and added the cloustack-api.xml file, but somehow it did not make it in the patch.
Can you still use the patch or you want a new one ?
- Sebastien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8233/#review13772
-----------------------------------------------------------
On Nov. 27, 2012, 9:19 a.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8233/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 9:19 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixing https://issues.apache.org/jira/browse/CLOUDSTACK-547 , multiple instances of CloudPlatform in docs
>
>
> This addresses bug 547.
>
>
> Diffs
> -----
>
> docs/en-US/add-clusters-ovm.xml 11e1a13
> docs/en-US/admin-guide.xml 512f7a9
> docs/en-US/aws-ec2-configuration.xml b8966c1
> docs/en-US/basic-zone-configuration.xml e27c914
> docs/en-US/basic-zone-guest-ip-addresses.xml d1d9135
> docs/en-US/basic-zone-physical-network-configuration.xml 83833a7
> docs/en-US/best-practices-primary-storage.xml 2f639b1
> docs/en-US/best-practices-secondary-storage.xml c2da7d8
> docs/en-US/cloudplatform-api.xml 3c4a914
> docs/en-US/configuring-projects.xml 0f84dd8
> docs/en-US/log-in-root-admin.xml bf499d6
> docs/en-US/manual-live-migration.xml 30a5c11
> docs/en-US/network-offerings.xml ccfb93c
> docs/en-US/network-service-providers.xml af57097
> docs/en-US/port-forwarding.xml b778693
> docs/en-US/primary-storage.xml 4cefa83
> docs/en-US/query-filter.xml fa5ea63
> docs/en-US/release-ip-address.xml 87b5300
> docs/en-US/roles.xml 473e37b
> docs/en-US/troubleshooting-lb-rules-fails.xml c507178
> docs/en-US/troubleshooting-maintenance-mode-not-working-on-vCenter.xml c4bf37f
> docs/en-US/using-swift-for-secondary-storage.xml bf238ca
> docs/en-US/vm-lifecycle.xml f5696ce
>
> Diff: https://reviews.apache.org/r/8233/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastien Goasguen
>
>
Re: Review Request: Fix for CLOUDSTACK-547
Posted by Gavin Lee <ga...@gmail.com>.
> On Nov. 27, 2012, 2:35 p.m., Gavin Lee wrote:
> > Hi, Sebastien
> > Thanks for the patch! I tested and it passed publican build for publican-adminguide.cfg.
> > Only one question, the file cloudplatform-api.xml should be renamed to cloudstack-api.xml rather than deleted. Could you please help to check this?
> >
> > Thanks again.
>
> Sebastien Goasguen wrote:
> Yes you are correct. I deleted it and added the cloustack-api.xml file, but somehow it did not make it in the patch.
> Can you still use the patch or you want a new one ?
It's OK, just want to confirm.
- Gavin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8233/#review13772
-----------------------------------------------------------
On Nov. 27, 2012, 9:19 a.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8233/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 9:19 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixing https://issues.apache.org/jira/browse/CLOUDSTACK-547 , multiple instances of CloudPlatform in docs
>
>
> This addresses bug 547.
>
>
> Diffs
> -----
>
> docs/en-US/add-clusters-ovm.xml 11e1a13
> docs/en-US/admin-guide.xml 512f7a9
> docs/en-US/aws-ec2-configuration.xml b8966c1
> docs/en-US/basic-zone-configuration.xml e27c914
> docs/en-US/basic-zone-guest-ip-addresses.xml d1d9135
> docs/en-US/basic-zone-physical-network-configuration.xml 83833a7
> docs/en-US/best-practices-primary-storage.xml 2f639b1
> docs/en-US/best-practices-secondary-storage.xml c2da7d8
> docs/en-US/cloudplatform-api.xml 3c4a914
> docs/en-US/configuring-projects.xml 0f84dd8
> docs/en-US/log-in-root-admin.xml bf499d6
> docs/en-US/manual-live-migration.xml 30a5c11
> docs/en-US/network-offerings.xml ccfb93c
> docs/en-US/network-service-providers.xml af57097
> docs/en-US/port-forwarding.xml b778693
> docs/en-US/primary-storage.xml 4cefa83
> docs/en-US/query-filter.xml fa5ea63
> docs/en-US/release-ip-address.xml 87b5300
> docs/en-US/roles.xml 473e37b
> docs/en-US/troubleshooting-lb-rules-fails.xml c507178
> docs/en-US/troubleshooting-maintenance-mode-not-working-on-vCenter.xml c4bf37f
> docs/en-US/using-swift-for-secondary-storage.xml bf238ca
> docs/en-US/vm-lifecycle.xml f5696ce
>
> Diff: https://reviews.apache.org/r/8233/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastien Goasguen
>
>
Re: Review Request: Fix for CLOUDSTACK-547
Posted by Gavin Lee <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8233/#review13772
-----------------------------------------------------------
Hi, Sebastien
Thanks for the patch! I tested and it passed publican build for publican-adminguide.cfg.
Only one question, the file cloudplatform-api.xml should be renamed to cloudstack-api.xml rather than deleted. Could you please help to check this?
Thanks again.
- Gavin Lee
On Nov. 27, 2012, 9:19 a.m., Sebastien Goasguen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8233/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 9:19 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixing https://issues.apache.org/jira/browse/CLOUDSTACK-547 , multiple instances of CloudPlatform in docs
>
>
> This addresses bug 547.
>
>
> Diffs
> -----
>
> docs/en-US/add-clusters-ovm.xml 11e1a13
> docs/en-US/admin-guide.xml 512f7a9
> docs/en-US/aws-ec2-configuration.xml b8966c1
> docs/en-US/basic-zone-configuration.xml e27c914
> docs/en-US/basic-zone-guest-ip-addresses.xml d1d9135
> docs/en-US/basic-zone-physical-network-configuration.xml 83833a7
> docs/en-US/best-practices-primary-storage.xml 2f639b1
> docs/en-US/best-practices-secondary-storage.xml c2da7d8
> docs/en-US/cloudplatform-api.xml 3c4a914
> docs/en-US/configuring-projects.xml 0f84dd8
> docs/en-US/log-in-root-admin.xml bf499d6
> docs/en-US/manual-live-migration.xml 30a5c11
> docs/en-US/network-offerings.xml ccfb93c
> docs/en-US/network-service-providers.xml af57097
> docs/en-US/port-forwarding.xml b778693
> docs/en-US/primary-storage.xml 4cefa83
> docs/en-US/query-filter.xml fa5ea63
> docs/en-US/release-ip-address.xml 87b5300
> docs/en-US/roles.xml 473e37b
> docs/en-US/troubleshooting-lb-rules-fails.xml c507178
> docs/en-US/troubleshooting-maintenance-mode-not-working-on-vCenter.xml c4bf37f
> docs/en-US/using-swift-for-secondary-storage.xml bf238ca
> docs/en-US/vm-lifecycle.xml f5696ce
>
> Diff: https://reviews.apache.org/r/8233/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sebastien Goasguen
>
>