You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/05 15:34:35 UTC

[jira] [Commented] (QPID-3514) Allow SSL and non-SSL connections on the same port

    [ https://issues.apache.org/jira/browse/QPID-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120961#comment-13120961 ] 

jiraposter@reviews.apache.org commented on QPID-3514:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2206/
-----------------------------------------------------------

Review request for Andrew Stitcher, michael goulish and Chug Rolke.


Summary
-------

Allow SSL and non-SSL connections on the same port. Patch contributed by Zane Bitter for use by the Matahari Project.


This addresses bug QPID-3514.
    https://issues.apache.org/jira/browse/QPID-3514


Diffs
-----

  /trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp 1179157 
  /trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp 1179157 
  /trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h 1179157 
  /trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.h 1179157 
  /trunk/qpid/cpp/src/qpid/sys/TCPIOPlugin.cpp 1179157 
  /trunk/qpid/cpp/src/qpid/sys/Socket.h 1179157 
  /trunk/qpid/cpp/src/qpid/sys/SslPlugin.cpp 1179157 

Diff: https://reviews.apache.org/r/2206/diff


Testing
-------

make check passes; tested with and without the multiplexing; tested client authentication; tested SASL EXTERNAL (requires reverting a recent change unrelated to this, see QPID-3522)


Thanks,

Gordon


                
> Allow SSL and non-SSL connections on the same port
> --------------------------------------------------
>
>                 Key: QPID-3514
>                 URL: https://issues.apache.org/jira/browse/QPID-3514
>             Project: Qpid
>          Issue Type: Improvement
>          Components: C++ Broker
>    Affects Versions: 0.12
>            Reporter: Zane Bitter
>         Attachments: ssl-mux.patch
>
>
> The Matahari Project (http:://matahariproject.org for the uninitiated) has run into an issue with our use of Qpid in that IANA policy is now to refuse to assign separate TCP ports for SSL/TLS-wrapped versions of protocols, which leaves us with only a single port assigned to Matahari.
> We would like to be able to accept both SSL and non-SSL connections on the same port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org