[jira] [Commented] (HBASE-18793) Remove deprecated methods in RegionObserver

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162633#comment-16162633 ] 

Duo Zhang commented on HBASE-18793:
-----------------------------------

These two methods
{code}
void preFlush(final ObserverContext<RegionCoprocessorEnvironment> c) throws IOException;
void postFlush(ObserverContext<RegionCoprocessorEnvironment> c) throws IOException;
{code}

are marked as deprecated for 5 years but they still alive in our code base... So I think we just remove the deprecated annotation and keep them there?

The reason why we deprecated them is that, we think the compaction hook is on store level but flush is on region level, so we added the store level flush hook and then deprecated region level flush hook methods.

But I think add a region level hook is reasonable as for flush, we always start from region level. It is impossible to request a flush for a single store, you can only request flush on a region and then after HBASE-10201(my first big patch), you can select stores to flush.

So I think we can just remove the deprecated annotation and keep them there.

Thanks.

> Remove deprecated methods in RegionObserver
> -------------------------------------------
>
>                 Key: HBASE-18793
>                 URL: https://issues.apache.org/jira/browse/HBASE-18793
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 3.0.0, 2.0.0-alpha-3
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 3.0.0, 2.0.0-alpha-4
>
>
> As we have already done lots of incomplete changes on CP APIs and it is allowed to do breaking changes on major release.
> Let's make the API clean.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)