[GitHub] ccollins476ad opened a new pull request #945: lwIP - Disable -Werror

[GitBox <gi...@apache.org>]

ccollins476ad opened a new pull request #945: lwIP - Disable -Werror
URL: https://github.com/apache/mynewt-core/pull/945
 
 
   The latest version of lwIP (2.0.3) provokes `unused-const-variable` warnings in some versions of gcc.  For example:
   
   ```
   Error: net/ip/lwip_base/src/apps/httpd/fsdata.c:137:27: error: 'dummy_align__index_html' defined but not used [-Werror=unused-const-variable=]
    static const unsigned int dummy_align__index_html = 2;
                              ^~~~~~~~~~~~~~~~~~~~~~~
   ```
   
   We can't disable this particular warning in the `lwip_core` package's cflags, because older versions of gcc complain when they don't recognize the command line option:
   
   ```
   cc1: error: unrecognized command line option '-Wno-unused-const-variable' [-Werror]
   ```
   
   The lwIP core codebase contains other warnings that we are filtering out with cflags, so it is clearly not meant to built with `-Werror`.
   
   This commit disables `-Werror` for the `lwip_core` package by adding the `-Wno-error` cflag.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services