You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by sarutak <gi...@git.apache.org> on 2014/07/12 03:26:10 UTC

[GitHub] spark pull request: [SPARK-2457] Inconsistent description in READM...

GitHub user sarutak opened a pull request:

    https://github.com/apache/spark/pull/1382

    [SPARK-2457] Inconsistent description in README about build option

    Now, we should use -Pyarn instead of SPARK_YARN when building but README says as follows.
    
    
        For Apache Hadoop 2.2.X, 2.1.X, 2.0.X, 0.23.x, Cloudera CDH MRv2, and other Hadoop versions
        with YARN, also set `SPARK_YARN=true`:
    
          # Apache Hadoop 2.0.5-alpha
          $ sbt/sbt -Dhadoop.version=2.0.5-alpha -Pyarn assembly
    
          # Cloudera CDH 4.2.0 with MapReduce v2
          $ sbt/sbt -Dhadoop.version=2.0.0-cdh4.2.0 -Pyarn assembly
    
          # Apache Hadoop 2.2.X and newer
          $ sbt/sbt -Dhadoop.version=2.2.0 -Pyarn assembly

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/spark SPARK-2457

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1382
    
----
commit e7b2d640117f009db5d6e6bcb4141b1ab47626a0
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Date:   2014-07-12T01:22:49Z

    Replaced "SPARK_YARN=true" with "-Pyarn" in README

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2457] Inconsistent description in READM...

Posted by rxin <gi...@git.apache.org>.

Github user rxin commented on the pull request:

    https://github.com/apache/spark/pull/1382#issuecomment-48801792
  
    Thanks. Merging this in master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2457] Inconsistent description in READM...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/1382


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: [SPARK-2457] Inconsistent description in READM...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1382#issuecomment-48798636
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---