You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/06/03 04:01:18 UTC

Re: Review Request 33934: Added the client address to http::Request.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33934/#review86347
-----------------------------------------------------------



3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/33934/#comment138307>

    This is incorrect, need to use `getpeername` here!


- Ben Mahler


On May 7, 2015, 5:47 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33934/
> -----------------------------------------------------------
> 
> (Updated May 7, 2015, 5:47 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-2519
>     https://issues.apache.org/jira/browse/MESOS-2519
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This information is not part of the http request, but it seems that many http libraries include it inside their "Request" abstraction as it is useful information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 5210ce07c8ea47cf67681455c2f5eb0fda4bb426 
>   3rdparty/libprocess/src/process.cpp 8ab0dbcd3e9b858244f1e67061897143204eada0 
>   3rdparty/libprocess/src/tests/http_tests.cpp dfdb233de93552ab7040647ee1958a85d47c9482 
> 
> Diff: https://reviews.apache.org/r/33934/diff/
> 
> 
> Testing
> -------
> 
> Added to the existing tests to ensure it is being set.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>