[GitHub] [maven-shared-utils] michael-o commented on a diff in pull request #113: [MSHARED-1072] fix blocking in StreamFeeder

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #113:
URL: https://github.com/apache/maven-shared-utils/pull/113#discussion_r1173486316


##########
src/main/java/org/apache/maven/shared/utils/cli/CommandLineUtils.java:
##########
@@ -436,7 +387,7 @@ public static String[] translateCommandline(String toProcess) throws CommandLine
         boolean inEscape = false;
         int state = normal;
         final StringTokenizer tok = new StringTokenizer(toProcess, "\"\' \\", true);

Review Comment:
   Off topic: This is sooo ugly...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org