You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/23 18:57:17 UTC

[GitHub] yuxihu commented on a change in pull request #12666: [MXNET-1111] Horovod support for MXNet

yuxihu commented on a change in pull request #12666: [MXNET-1111] Horovod support for MXNet
URL: https://github.com/apache/incubator-mxnet/pull/12666#discussion_r227522550
 
 

 ##########
 File path: src/io/iter_image_recordio_2.cc
 ##########
 @@ -285,9 +285,9 @@ inline bool ImageRecordIOParser2<DType>::ParseNext(DataBatch *out) {
     shape_vec.push_back(param_.label_width);
     TShape label_shape(shape_vec.begin(), shape_vec.end());
 
-    out->data.at(0) = NDArray(data_shape, Context::CPUPinned(0), false,
+    out->data.at(0) = NDArray(data_shape, Context::CPU(0), false,
 
 Review comment:
   For my own understanding, why do we change to CPU from CPUPinned in this PR? Is it going to cause issue if we stick to CPUPinned when conduct distributed training with Horovod?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services